Skip to content

Conversation

@dannda
Copy link
Contributor

@dannda dannda commented Nov 3, 2025

Description

set var encoding button icon to minus when selected

fixes #194

Type of change

  • πŸ› Bug fix (non-breaking change that resolves an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • ⚑ Optimisation (non-breaking improvement to performance or efficiency)
  • 🧩 Documentation (adds or improves documentation)
  • 🧱 Maintenance (refactor, dependency update, CI/CD, etc.)
  • πŸ”₯ Breaking change (fix or feature that causes existing functionality to change)

Checklist

  • All tests pass (eg. npm test)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)
  • Documentation updated (if required)

Copilot AI review requested due to automatic review settings November 3, 2025 12:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the UI feedback for color encoding selection by dynamically changing the icon based on the active state. When a variable or set is active in multiple selection mode, a minus icon is shown; otherwise, a plus icon is displayed.

  • Added dynamic icon switching between faMinus and faPlus based on the isActive state
  • Updated both VarSet.jsx and VarItem.jsx components to provide consistent visual feedback

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/lib/components/var-list/VarSet.jsx Added faMinus import and conditional icon rendering for SelectionSet component
src/lib/components/var-list/VarItem.jsx Added faMinus import and conditional icon rendering for SelectionItem component

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dannda dannda requested a review from davehorsfall November 3, 2025 12:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
βœ… Project coverage is 15.57%. Comparing base (5135761) to head (bf6ed5b).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/lib/components/var-list/VarSet.jsx 0.00% 5 Missing ⚠️
src/lib/components/var-list/VarItem.jsx 20.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #196      +/-   ##
==========================================
- Coverage   15.58%   15.57%   -0.01%     
==========================================
  Files          62       62              
  Lines        2092     2099       +7     
  Branches      504      511       +7     
==========================================
+ Hits          326      327       +1     
- Misses       1706     1711       +5     
- Partials       60       61       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@davehorsfall davehorsfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a little more work to update the icons and title depending on the mode (single or multi select).

image

@dannda dannda merged commit 37677c9 into dev Nov 5, 2025
1 check passed
@dannda dannda deleted the fix/var-icon branch November 5, 2025 12:59
@davehorsfall
Copy link
Member

πŸŽ‰ This PR is included in version 1.4.5 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants