-
Notifications
You must be signed in to change notification settings - Fork 0
fix: set var encoding button icon to minus when selected #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the UI feedback for color encoding selection by dynamically changing the icon based on the active state. When a variable or set is active in multiple selection mode, a minus icon is shown; otherwise, a plus icon is displayed.
- Added dynamic icon switching between
faMinusandfaPlusbased on theisActivestate - Updated both
VarSet.jsxandVarItem.jsxcomponents to provide consistent visual feedback
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/components/var-list/VarSet.jsx | Added faMinus import and conditional icon rendering for SelectionSet component |
| src/lib/components/var-list/VarItem.jsx | Added faMinus import and conditional icon rendering for SelectionItem component |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #196 +/- ##
==========================================
- Coverage 15.58% 15.57% -0.01%
==========================================
Files 62 62
Lines 2092 2099 +7
Branches 504 511 +7
==========================================
+ Hits 326 327 +1
- Misses 1706 1711 +5
- Partials 60 61 +1 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
davehorsfall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
π This PR is included in version 1.4.5 π The release is available on GitHub release Your semantic-release bot π¦π |

Description
set var encoding button icon to minus when selected
fixes #194
Type of change
Checklist
npm test)pre-commit run --all-files)