Fix for 'Blog feed rendering with html formatting on landing page #4'#6
Fix for 'Blog feed rendering with html formatting on landing page #4'#6DATAVXN wants to merge 4 commits intohandlingar:mainfrom
Conversation
|
Btw this is my first contribution and would appreciate feedback on pull request, want to make sure you received on your end. Thank you. |
|
@mattiasaxell Do you see this page? My pull request is here. I also see it on my vs code. I'm going to close it and resubmit it. |
|
Hello @mattiasaxell, I resubmitted and reopened new pull request and it brings me back to this string. I can see the change log with my changes also:
|
|
@DATAVXN Will check as soon as I can, hopefully tomorrow! |
roztownsend
left a comment
roztownsend
left a comment
There was a problem hiding this comment.
I see a lot of hard-coded HTML here. Shouldn't the blog entries be an embedded RSS feed?
|
Maybe propose that and see if it helps him. |
|
@DATAVXN As @roztownsend writes this blog is an embedded RSS feed here: https://about.handlingar.se/category/handlingar/feed/ rendered on the front page. We can't replace it with hard coded HTML. Something is wrong with the embedding. |
|
@mattiasaxell @roztownsend I'm understanding @roztownsend writes this blog? Nice! ok. I'll replace entries w RSS feed. |
|
@mattiasaxell @roztownsend See pull request 'Embedded RSS feed in place of blog entries #8' off new branch. |
|
@DATAVXN I don't write the blog. I am a frontend volunteer with Handlingar. I'll check our your other pull request. |
3 participants
Added updated code on new landingpage.html. Thank you in advance for your feedback.