Improve routes command handling of long routes#293
Open
hmaddocks wants to merge 1 commit intohanami:mainfrom
Open
Improve routes command handling of long routes#293hmaddocks wants to merge 1 commit intohanami:mainfrom
hmaddocks wants to merge 1 commit intohanami:mainfrom
Conversation
Make it handle very long paths better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am porting a Rails app to Hanami that has some deeep routes with long controller names. This is a sample of the output from the
hanami routescommand. The columns of the output is being squashed together.This is after this fix. The column alignment is being maintained.
The code ieterates the routes twice. Once to find the max column width and second to print out the routes. This might be slow for an application with a lot of routes.
The new code also maintains a 5 character spacing between columns.