Make config.formats clearer and more flexible

.github/workflows/ci.yml

@@ -17,7 +17,6 @@ jobs:
           - "3.4"
           - "3.3"
           - "3.2"
-          - "3.1"
         rack:
           - "~> 2.0"
           - "~> 3.0"

lib/hanami/action.rb

@@ -272,6 +272,15 @@ def self.prepend_after(...)
     # @since 2.0.0
     # @api public
     def self.format(...)
+      msg = <<~TEXT
+        Hanami::Action `format` is deprecated and will be removed in Hanami 2.4.
+
+        Please use `config.formats.accept` instead.
+
+        See https://guides.hanamirb.org/v2.3/actions/formats-and-mime-types/ for details.
+      TEXT
+      warn(msg, category: :deprecated)
+
       config.format(...)
     end
 
@@ -326,7 +335,7 @@ def call(env)
           session_enabled: session_enabled?
         )
 
-        enforce_accepted_mime_types(request)
+        enforce_accepted_media_types(request)
 
         _run_before_callbacks(request, response)
         handle(request, response)
@@ -413,7 +422,7 @@ def _requires_no_body?(res)
 
     # @since 2.0.0
     # @api private
-    def enforce_accepted_mime_types(request)
+    def enforce_accepted_media_types(request)
       return if config.formats.empty?
 
       Mime.enforce_accept(request, config) { return halt 406 }
@@ -596,7 +605,7 @@ def finish(req, res, halted)
       _empty_headers(res) if _requires_empty_headers?(res)
       _empty_body(res) if res.head?
 
-      res.set_format(Action::Mime.detect_format(res.content_type, config))
+      res.set_format(Mime.format_from_media_type(res.content_type, config))
       res[:params] = req.params
       res[:format] = res.format
       res

lib/hanami/action/config.rb

@@ -68,7 +68,8 @@ def handle_exception(exceptions)
 
       # Sets the format (or formats) for the action.
       #
-      # To configure custom formats and MIME type mappings, call {Formats#add formats.add} first.
+      # To configure custom formats and MIME type mappings, call {Formats#register formats.register}
+      # first.
       #
       # @example
       #   config.format :html, :json
@@ -82,10 +83,20 @@ def handle_exception(exceptions)
       # @since 2.0.0
       # @api public
       def format(*formats)
+        msg = <<~TEXT
+          Hanami::Action `config.format` is deprecated and will be removed in Hanami 2.4.
+
+          Please use `config.formats.register` and/or `config.formats.accept` instead.
+
+          See https://guides.hanamirb.org/v2.3/actions/formats-and-mime-types/ for details.
+        TEXT
+        warn(msg, category: :deprecated)
+
         if formats.empty?
           self.formats.values
         else
           self.formats.values = formats
+          self.formats.default = formats.first
         end
       end