Added ability to update diagram from last used view#105
Open
steghoja wants to merge 3 commits intohallvard:masterfrom
Open
Added ability to update diagram from last used view#105steghoja wants to merge 3 commits intohallvard:masterfrom
steghoja wants to merge 3 commits intohallvard:masterfrom
Conversation
As an extension to issue hallvard#93, this commit introduces changes to allow updating the diagram based on the view that PlantUML last used (i.e., the currentPart) instead of the view that is currently in focus. To make this work, PlantUML now ignores its own view (i.e., does not set the view in which it renders the diagram as the current part) and has a new method updateDiagramTextFromCurrentPart() which updates the diagram based on the currently set currentPart.
Author
|
I rebased this on the current version today and am hoping that you might be able to include this in 1.1.25. Actually, my comment was inaccurate: this change is an extension to issue #92. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an extension to issue #93, this commit introduces
changes to allow updating the diagram based on the
view that PlantUML last used (i.e., the currentPart)
instead of the view that is currently in focus. To make
this work, PlantUML now ignores its own view (i.e., does
not set the view in which it renders the diagram as the
current part) and has a new method
updateDiagramTextFromCurrentPart() which updates the
diagram based on the currently set currentPart.