Allow a comma separated upgrade header#142
Closed
jhofstee wants to merge 1 commit intohalfgaar:masterfrom
Closed
Conversation
The upgrade header might be comma separated and FlashMQ shouldn't refuse to upgrade in such a case. This splits and trims the upgrade header first. In our case the header is actually send by accident. It used to be: Upgrade: websocket\r\n Upgrade: websocket\r\n But newer nginx proxies transform that into: Upgrade: websocket, websocket\r\n And hence a websocket connection could no longer be established.
jhofstee
force-pushed
the
comma-separated-upgrade-header
branch
from
a8217fb to
5c5efe0
Compare
Owner
|
Merged. Github lost track because I edited one letter in your commit message, so closing manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade header might be comma separated and FlashMQ shouldn't refuse to upgrade in such a case. This splits and trims the upgrade header first.
In our case the header is actually send by accident. It used to be:
But newer nginx proxies transform that into:
And hence a websocket connection could no longer be established.