Allow images in resource folder and resize for mobile#31
Open
ilja-radusch wants to merge 5 commits intohalf-duplex:mainfrom
Open
Allow images in resource folder and resize for mobile#31ilja-radusch wants to merge 5 commits intohalf-duplex:mainfrom
ilja-radusch wants to merge 5 commits intohalf-duplex:mainfrom
Conversation
half-duplex
requested changes
Oct 17, 2025
Owner
half-duplex
left a comment
half-duplex
left a comment
There was a problem hiding this comment.
Thanks for the PR! Responsive images is something I wanted to do but never got to figuring out how.
Not-thoroughly-verified rebase: https://github.com/half-duplex/hugo-arcana/tree/image-resize
| font-style:normal; | ||
| font-weight:300; | ||
| font-display:auto; | ||
| font-display:swap; |
Owner
There was a problem hiding this comment.
Why swap? I assume responsiveness, but is it a best practice or solving a specific problem?
Comment on lines
+14
to
+17
| {{- $breakpoints := slice 1920 1600 1366 900 600 360 -}} | ||
| {{- range $bp := $breakpoints }} | ||
| {{- if le $bp .Width }} | ||
| {{- with .Resize (printf "%dx %s" $bp $image_options) }} |
Owner
There was a problem hiding this comment.
Should this exclude sizes larger than the original image?
Comment on lines
+30
to
+31
| width="{{ .Width }}" | ||
| height="{{ .Height }}" |
Owner
There was a problem hiding this comment.
Moving the exampleSite images from static/ to assets/ to test, this makes the front page block show a very tall left 10% of the image. Similar scale/size issues on the post list and post pages.
https://sec.gd/hugo/themes/arcana/dev/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.