Cauchy test 3 #190
Open
Cauchy test 3 #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staplejw
changed the title
Latest master
Contributor
|
Done in-lining. Failure looks like this now |
JacquesCarette
requested changes
Apr 24, 2018
| #cauchy(0,1/2) | ||
| X1 <~ normal(+0/1, 1/1) | ||
| X2 <~ normal(+0/1, 1/1) | ||
| return X1/X2*(+1/2) No newline at end of file |
Contributor
There was a problem hiding this comment.
So if you rewrite this as 1/X2*X1*(+1/2) then your test will pass.
Contributor
|
OK fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure in: 6:RoundTrip:7:3:t_cauchy_reciprocal_transformation:0
haskell/Tests/TestTools.hs:130
expected:
stdNormal = p <~ normal(nat2real(0), nat2prob(1))
return p
stdCauchy = X1 <~ stdNormal
X2 <~ stdNormal
return X1 / X2
cauchy = fn a real:
fn alpha prob:
X <~ stdCauchy
return a + prob2real(alpha) * X
X <~ cauchy(nat2real(0), 1/2)
return X
but got:
p5 <~ normal(+0/1, 1/1)
p3 <~ normal(+0/1, 1/1)
return p5 / p3 * (+1/2)
Cases: 338 Tried: 293 Errors: 2 Failures: 26
Failure in: 6:RoundTrip:7:3:t_cauchy_reciprocal_transformation:1
haskell/Tests/TestTools.hs:130
expected:
stdNormal = p <~ normal(nat2real(0), nat2prob(1))
return p
stdCauchy = X1 <~ stdNormal
X2 <~ stdNormal
return X1 / X2
cauchy = fn a real:
fn alpha prob:
X <~ stdCauchy
return a + prob2real(alpha) * X
X <~ cauchy(nat2real(0), 1/2)
return X
but got:
p5 <~ normal(+0/1, 1/1)
p3 <~ normal(+0/1, 1/1)
return 1/ p5 * p3 * (+1/2)
Cases: 338 Tried: 294 Errors: 2 Failures: 27
Cases: 338 Tried: 295 Errors: 2 Failures: 27
Cases: 338 Tried: 296 Errors: 2 Failures: 27
Cases: 338 Tried: 297 Errors: 2 Failures: 27