Open
Conversation
* Moves src/*.{c,h} to src/_cffi_src
* Moves vi3o/*.py to src/vi3o
* Moves build_* to src/_cffi_src
* Moves test/ to tests/
* Moves misc to scripts/
* Updates build_*.py and setup.py for new layout
* Updates manifest
* Restructures setup.py
.. to provide improved testing of different python versions, as well as tooling for running linting, formatting and coverage reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is a fairly big one - so let me know if you want me to break this up or improve it in any way.
In short, this pull request reshuffles the files in the repository to a src-layout in order to avoid issues with testability (see e.g. https://hynek.me/articles/testing-packaging/ ) and adds support for tox.
With tox we improve testing of different python versions, and provide other code quality tasks such as linting and formatting. Finally, the pull request adds an init_env.sh that can be sourced in order to facilitate a simple bootstrapping of development.
I indent to follow up this pull request with bug fixes, minor changes to documentation and improvements to the continuous integration of the repository.