Fix SignalR client disconnection issue by reverting to default timeouts #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom timeout configuration (ClientTimeoutInterval: 2 minutes, KeepAliveInterval: 30 seconds) was causing disconnections during active use due to a timing mismatch with the client's default ServerTimeout of 30 seconds. When the server sends keep-alive pings every 30 seconds but the client expects messages within 30 seconds, any network latency or processing delay causes the client to timeout before the server's ping arrives. Reverting to SignalR defaults provides the recommended 2:1 ratio: - Server KeepAliveInterval: 15 seconds (default) - Server ClientTimeoutInterval: 30 seconds (default) - Client KeepAliveInterval: 15 seconds (default) - Client ServerTimeout: 30 seconds (default) This ensures sufficient buffer time for network jitter and prevents spurious disconnections.
Add proper initialization guards and null checks to prevent InvalidOperationException when connections are being torn down: - Add EnsureInitialized() to UpdateProperties to ensure presenter exists before validation - Add EnsureInitialized() to Internal_AddViewer to prevent adding viewers to uninitialized grains - Add null guard in Internal_RemoveClient viewer path to handle race condition where presenter has already disconnected and nullified _presenter - Add EnsureInitialized() to Internal_DisplayNameChanged to prevent calls on uninitialized grains The race condition occurred when: 1. Presenter disconnects first, nullifying _presenter 2. Viewer disconnects immediately after 3. Viewer removal attempts to call NotifyConnectionChangedAsync() which requires presenter Now viewer removal gracefully skips notification if presenter is already gone, since the connection is effectively dead and all clients have already been notified via ConnectionStopped. Fixes: System.InvalidOperationException: ConnectionGrain not initialized: ConnectionId=..., presenter=null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.