Fix chat window not reopening after close #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user closed the chat window with the X button, the window was hidden instead of closed to preserve state. However, when trying to reopen it, the parent ViewModel would call Activate() on the existing WindowHandle, which only activated the window without showing it first. This caused the window to remain hidden. The fix ensures that WindowHandle.Activate() calls Show() before Activate() to make the window visible, similar to ChatView.ShowAndActivate().
Removed the workaround that hid the chat window instead of closing it. The window now closes normally when the user clicks X, which is simpler and cleaner. When reopened, a fresh window and ViewModel are created. Changes: - Removed _forceClose field and ForceClose() method from ChatView - Simplified OnClosing to perform cleanup and allow normal close - Reverted WindowHandle.Activate() to not call Show() (no longer needed)
The ShowAndActivate method was only used when creating new chat windows, where the minimized state check was unnecessary. Simplified by calling Show() and Activate() directly in the dialog service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.