Skip to content

Conversation

@hadv
Copy link
Owner

@hadv hadv commented Dec 6, 2025

Summary

This PR resolves all npm security vulnerabilities in the frontend package.

Changes

Package Before After Severity Issue
@walletconnect/web3wallet 1.16.1 1.16.0 Critical elliptic ≤6.6.0 - ECDSA private key extraction
vite 5.x 7.2.6 Moderate esbuild ≤0.24.2 - dev server request vulnerability
hono - Updated High Improper authorization, CORS bypass
js-yaml - Updated Moderate Prototype pollution

Security Audit Results

Before

9 vulnerabilities (3 moderate, 1 high, 5 critical)

After

found 0 vulnerabilities

Verification

  • npm audit shows 0 vulnerabilities
  • npm run build succeeds
  • npm run test:run - 78/78 tests pass

Notes

  • @walletconnect/web3wallet shows a deprecation warning suggesting migration to @reown/walletkit. This is a future consideration for a separate PR as it requires code changes.
  • The Vite upgrade from v5 to v7 is a major version bump but build and tests pass successfully.

Pull Request opened by Augment Code with guidance from the PR author

- Update @walletconnect/web3wallet 1.16.1 → 1.16.0 (fixes critical elliptic vulnerability)
- Update vite 5.x → 7.2.6 (fixes moderate esbuild dev server vulnerability)
- Update hono (fixes high severity auth/CORS issues)
- Update js-yaml (fixes moderate prototype pollution)

Security audit now shows 0 vulnerabilities for both frontend and backend.

Resolves: CVE in elliptic ≤6.6.0 (ECDSA private key extraction)
Resolves: CVE in esbuild ≤0.24.2 (dev server request vulnerability)
Resolves: CVE in hono ≤4.10.2 (improper authorization, CORS bypass)
Resolves: CVE in js-yaml 4.0.0-4.1.0 (prototype pollution)
@hadv hadv merged commit f537c6b into main Dec 6, 2025
4 checks passed
@hadv hadv deleted the fix/npm-security-vulnerabilities branch December 6, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants