This repository was archived by the owner on Jul 4, 2023. It is now read-only.
Fix typo in gerber.py for filling zeros in y value.#20
Open
lendres wants to merge 2 commits intohadleyrich:masterfrom
Open
Fix typo in gerber.py for filling zeros in y value.#20lendres wants to merge 2 commits intohadleyrich:masterfrom
lendres wants to merge 2 commits intohadleyrich:masterfrom
Conversation
Line 248 From: x_digs_total To: y_digs_total
The regular expression search for both X and Y at the same time is redundant and can be removed. The searches for X and Y individually that follow it will catch cases where X and Y are combined. The regular expression is searching for a substring of the line, not trying to match an entire line, therefore, it does not matter if X is alone or part of X and Y together on a single line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 248
From: x_digs_total
To: y_digs_total
It seems like the x total digits got used instead of the y total digits in this line.