Skip to content

Add group/curve trait to bip-340#17

Open
cmester0 wants to merge 4 commits intohacspec:mainfrom
cmester0:group_trait
Open

Add group/curve trait to bip-340#17
cmester0 wants to merge 4 commits intohacspec:mainfrom
cmester0:group_trait

Conversation

@cmester0
Copy link

No description provided.

@cmester0 cmester0 marked this pull request as ready for review March 14, 2024 17:54
@cmester0
Copy link
Author

cmester0 commented Mar 14, 2024

We could switch to using the zkcrypto/group trait, instead of using nat_mod, however it does use mutable borrows, which does not fit well with Hax.

@tarcieri
Copy link

however it does use mutable borrows

Are you talking about for the *Assign traits? Those are straight out of core::ops and all have non-*Assign variants which use immutable borrows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments