Skip to content

Standardize queue management and info display across input nodes #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 234 commits into
base: main
Choose a base branch
from
Draft

Standardize queue management and info display across input nodes #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
234 commits
Select commit Hold shift + click to select a range
645e5cf
Add comprehensive security summary documentation
Copilot Dec 7, 2025
f91017f
Merge pull request #180 from hackolite/copilot/fix-audio-merging-issue
hackolite Dec 7, 2025
ab0d81f
Initial plan
Copilot Dec 7, 2025
aabeaec
Add hand tracking node for pose estimation specialized for hands
Copilot Dec 7, 2025
41f58e3
Add comprehensive documentation for hand tracking node
Copilot Dec 7, 2025
c331477
Fix coordinate type conversion issues in hand tracking visualization
Copilot Dec 7, 2025
5595a0e
Add comprehensive implementation summary and complete hand tracking f…
Copilot Dec 7, 2025
cb0713d
Add security summary for hand tracking implementation
Copilot Dec 7, 2025
7a2210e
Merge pull request #181 from hackolite/copilot/add-hand-pose-estimati…
hackolite Dec 7, 2025
f14d1da
Initial plan
Copilot Dec 9, 2025
d1cc3e9
Implement synchronized audio chunk merging through pipeline
Copilot Dec 9, 2025
0eb7ccd
Address code review feedback
Copilot Dec 9, 2025
d05d9bf
Merge pull request #182 from hackolite/copilot/check-audio-video-sync
hackolite Dec 9, 2025
4475390
Initial plan
Copilot Dec 9, 2025
855d1e3
Fix audio synchronization: collect per slot, merge by timestamp
Copilot Dec 9, 2025
06821f4
Update documentation to reflect the actual audio sync bug and fix
Copilot Dec 9, 2025
c23b231
Address code review: improve comments and fix sample rate handling
Copilot Dec 9, 2025
87bb74d
Add security summary for audio sync fix
Copilot Dec 9, 2025
f714286
Initial plan
Copilot Dec 10, 2025
c747656
Fix audio timestamp preservation in SyncQueue, ImageConcat, and Video…
Copilot Dec 10, 2025
d921091
Add comprehensive test for video/audio sync pipeline and address code…
Copilot Dec 10, 2025
eb1fa45
Add comprehensive documentation for video/audio sync fix
Copilot Dec 10, 2025
0022d7d
Add security summary for video/audio sync fix
Copilot Dec 10, 2025
2e1d703
Add implementation summary - fix complete and ready for production
Copilot Dec 10, 2025
b64ebc4
Merge pull request #184 from hackolite/copilot/fix-video-processing-i…
hackolite Dec 10, 2025
13784b4
Initial plan
Copilot Dec 10, 2025
25fe0e7
Add background video worker module and integrate with VideoWriter node
Copilot Dec 10, 2025
2a4b4b6
Add comprehensive tests for background video worker with all tests pa…
Copilot Dec 10, 2025
1965cd1
Add comprehensive documentation and security summary for background w…
Copilot Dec 10, 2025
aececb1
implement-background-video-creation
hackolite Dec 10, 2025
e0a0bd9
Merge branch 'main' into copilot/fix-audio-video-sync-issue
hackolite Dec 10, 2025
5050ddb
Merge pull request #183 from hackolite/copilot/fix-audio-video-sync-i…
hackolite Dec 10, 2025
b5b1ec1
Initial plan
Copilot Dec 10, 2025
02b5a36
Add system verification and enhanced logging infrastructure
Copilot Dec 10, 2025
b4eacda
Enhance video worker logging and add comprehensive tests
Copilot Dec 10, 2025
404b73d
Add UI controls for pause/resume/cancel and enhance progress display
Copilot Dec 10, 2025
b46f7c1
Add comprehensive documentation for logging, verification, and video …
Copilot Dec 10, 2025
090e574
Address code review feedback - remove duplicate code and clarify logg…
Copilot Dec 10, 2025
fef1838
Add final implementation summary - all requirements complete
Copilot Dec 10, 2025
7730355
Merge pull request #186 from hackolite/copilot/add-video-encoding-log…
hackolite Dec 10, 2025
b1ffdaa
Initial plan
Copilot Dec 10, 2025
2434777
Fix: Increase queue size from 10 to 800 for proper SyncQueue/VideoWri…
Copilot Dec 10, 2025
7a9f030
Refactor: Extract DEFAULT_QUEUE_SIZE constant to eliminate duplication
Copilot Dec 10, 2025
88fd666
Merge pull request #187 from hackolite/copilot/verify-input-queue-size
hackolite Dec 10, 2025
b3b4ce0
Initial plan
Copilot Dec 10, 2025
f22f817
Implement dynamic queue sizing based on FPS and chunk duration
Copilot Dec 10, 2025
b34c505
Add comprehensive tests and documentation for queue sizing
Copilot Dec 10, 2025
809cc4f
Address code review feedback: add validation, improve encapsulation, …
Copilot Dec 10, 2025
c178e95
Add security summary for queue memory optimization
Copilot Dec 10, 2025
78613dd
Merge pull request #188 from hackolite/copilot/fix-video-crash-issue
hackolite Dec 10, 2025
e10b5e6
Initial plan
Copilot Dec 10, 2025
b780b76
Remove useless .md files, add ARCHITECTURE.md, replace prints with lo…
Copilot Dec 10, 2025
f04a401
Merge pull request #189 from hackolite/copilot/remove-unused-md-files
hackolite Dec 10, 2025
0c8e6f1
Initial plan
Copilot Dec 10, 2025
ee69a37
Update audio chunk duration to 3s, queue sizes, and SyncQueue defaults
Copilot Dec 10, 2025
e7bef28
Add tests and improve audio queue documentation
Copilot Dec 10, 2025
d76a23e
Merge pull request #190 from hackolite/copilot/configure-audio-chunki…
hackolite Dec 10, 2025
e22f089
Initial plan
Copilot Dec 10, 2025
e7e05d9
Fix KeyError: None in SyncQueue node when slot_type is None
Copilot Dec 10, 2025
96b30b1
Merge pull request #191 from hackolite/copilot/fix-keyerror-in-sync-q…
hackolite Dec 10, 2025
9e28d4b
Initial plan
Copilot Dec 10, 2025
15389bd
Fix SyncQueue slot type changes - update UI and clear buffers
Copilot Dec 10, 2025
98f5d6b
Add comprehensive documentation for SyncQueue type selection
Copilot Dec 10, 2025
241a1dc
Refactor: Extract type mapping dictionaries as class constants
Copilot Dec 10, 2025
c916239
Merge pull request #192 from hackolite/copilot/check-sync-queue-slot-…
hackolite Dec 10, 2025
cdf8616
Optimize queue synchronization node performance
hackolite Dec 10, 2025
124b012
Initial plan
Copilot Dec 13, 2025
f6be151
Add timestamp injection to audio chunks in Video node
Copilot Dec 13, 2025
cc42155
Update test to accommodate timestamp in return value
Copilot Dec 13, 2025
229ee0f
Fix: Copy audio_chunk_data dict before modifying to prevent cache cor…
Copilot Dec 13, 2025
3f20105
Add type check and clarifying comment for audio timestamp injection
Copilot Dec 13, 2025
91ddb38
Merge pull request #193 from hackolite/copilot/add-syncqueue-node-for…
hackolite Dec 13, 2025
759d29b
Initial plan
Copilot Dec 13, 2025
8e04db3
Fix audio retention coherence: increase audio queue size from 3 to 4
Copilot Dec 13, 2025
6b05ff1
Update documentation with audio/image coherence explanation
Copilot Dec 13, 2025
4a01ce2
Merge pull request #194 from hackolite/copilot/fix-audio-data-coherence
hackolite Dec 13, 2025
b0e9f21
Initial plan
Copilot Dec 13, 2025
7d28bff
Implement count-based synchronization for SyncQueue node
Copilot Dec 13, 2025
3dd4e89
Fix default slot creation to work correctly with save/load
Copilot Dec 13, 2025
abd5f41
Address code review: remove O(n) duplicate check and add safety check…
Copilot Dec 13, 2025
155a8d9
Merge pull request #195 from hackolite/copilot/simplify-syncqueue-logic
hackolite Dec 13, 2025
c873921
Initial plan
Copilot Dec 13, 2025
63fd35d
Fix SyncQueue output display to show number of elements output
Copilot Dec 13, 2025
c822d16
Merge pull request #196 from hackolite/copilot/fix-sync-queue-output
hackolite Dec 13, 2025
5f28e21
Initial plan
Copilot Dec 13, 2025
671ee27
Remove audio chunk overlap in video node - set step_duration to equal…
Copilot Dec 13, 2025
7e1ad1f
Fix test comment to accurately describe chunk calculation
Copilot Dec 13, 2025
66bae2b
Fix test assertion to check complete docstring text
Copilot Dec 13, 2025
b39f50f
Fix test to check actual function signature for no-overlap configuration
Copilot Dec 13, 2025
1673107
Merge pull request #197 from hackolite/copilot/create-chunks-with-nod…
hackolite Dec 13, 2025
70d7717
Initial plan
Copilot Dec 13, 2025
b13f9c6
Add chunk size slider to video input node
Copilot Dec 13, 2025
7b2a997
Update tests for 2.0 second default chunk size
Copilot Dec 13, 2025
1f76727
Add test for chunk size slider functionality
Copilot Dec 13, 2025
6d39d39
Merge pull request #198 from hackolite/copilot/add-video-chunk-slider
hackolite Dec 13, 2025
454ec01
Initial plan
Copilot Dec 13, 2025
8ce971d
Add queue size labels to Video node displaying image and audio queue …
Copilot Dec 13, 2025
75eb96a
Add test for video node queue labels
Copilot Dec 13, 2025
289f5ec
Improve error handling for queue info retrieval with separate try-cat…
Copilot Dec 13, 2025
532a51a
Use consistent tag_node_name variable throughout update method
Copilot Dec 13, 2025
82bc001
Make test more flexible by checking for presence of queue label compo…
Copilot Dec 13, 2025
0e42e09
Merge pull request #199 from hackolite/copilot/add-queue-element-counts
hackolite Dec 13, 2025
f81f843
Initial plan
Copilot Dec 13, 2025
76dbac3
Implement in-memory audio chunk storage for video input node
Copilot Dec 13, 2025
ebcafec
Update tests to verify in-memory audio chunk storage
Copilot Dec 13, 2025
adccbc2
Address code review feedback: improve docstrings and test precision
Copilot Dec 13, 2025
4095b5c
Merge pull request #200 from hackolite/copilot/load-audio-into-memory
hackolite Dec 13, 2025
65b3780
Initial plan
Copilot Dec 13, 2025
a8ac36b
Remove Skip Rate slider and add Queue Chunks slider with dynamic queu…
Copilot Dec 13, 2025
97b1f18
Add tests and optimize queue resizing to happen only once per video load
Copilot Dec 13, 2025
01e9dd1
Improve documentation for _queues_resized instance variable
Copilot Dec 13, 2025
d4aa550
Merge pull request #201 from hackolite/copilot/remove-skip-rate-slider
hackolite Dec 13, 2025
b80da5d
Initial plan
Copilot Dec 13, 2025
95e0b9e
Fix video node queue display - show maxsize instead of current size
Copilot Dec 13, 2025
a130de3
Improve docstring for maxsize() method
Copilot Dec 13, 2025
cec0d8c
Merge pull request #202 from hackolite/copilot/fix-node-video-queue-size
hackolite Dec 13, 2025
c5b76ad
Initial plan
Copilot Dec 13, 2025
5d87363
Display both queue size and maxsize for Video node
Copilot Dec 13, 2025
c0d0980
Merge pull request #203 from hackolite/copilot/add-queue-count-for-in…
hackolite Dec 13, 2025
8359dcf
Initial plan
Copilot Dec 13, 2025
f2def6d
Fix queue size calculation to use target_fps instead of video fps
Copilot Dec 13, 2025
4874d33
Merge pull request #204 from hackolite/copilot/fix-queue-size-calcula…
hackolite Dec 13, 2025
a6972bf
Initial plan
Copilot Dec 13, 2025
930abee
Add JSON stream collection and format-specific merge logic
Copilot Dec 13, 2025
305b003
Add tests for concat stream merge functionality
Copilot Dec 13, 2025
ed92119
Address code review feedback - improve JSON serialization and efficiency
Copilot Dec 13, 2025
302dcf5
Final cleanup - optimize test code efficiency
Copilot Dec 13, 2025
b0acfe4
Merge pull request #205 from hackolite/copilot/concat-audio-video-str…
hackolite Dec 13, 2025
152b13b
Initial plan
Copilot Dec 13, 2025
813f4db
Implement video/audio duration synchronization in VideoWriter
Copilot Dec 13, 2025
ddfcb78
Add comprehensive tests for stream synchronization and aggregation
Copilot Dec 13, 2025
1c65229
Fix resource leaks and code quality issues from code review
Copilot Dec 13, 2025
775db7d
Address remaining code review issues - improve robustness
Copilot Dec 13, 2025
3c59357
Final robustness improvements - add edge case handling
Copilot Dec 13, 2025
19e98d2
Add comprehensive implementation summary documentation
Copilot Dec 13, 2025
bd884fe
Merge pull request #206 from hackolite/copilot/implement-video-concat…
hackolite Dec 13, 2025
3772d55
Initial plan
Copilot Dec 13, 2025
8dd5546
Pass target_fps and chunk_duration from Video node to VideoWriter
Copilot Dec 13, 2025
d8d6984
Add comprehensive tests for workflow verification
Copilot Dec 13, 2025
134ce1e
Address code review feedback and add documentation
Copilot Dec 13, 2025
8bd939f
Add final implementation notes and documentation
Copilot Dec 13, 2025
bead501
Add completion summary - Task complete ✅
Copilot Dec 13, 2025
17a60a1
Merge pull request #207 from hackolite/copilot/verify-audio-video-wor…
hackolite Dec 13, 2025
fad308a
Initial plan
Copilot Dec 13, 2025
fb9cd58
Add crash logging infrastructure (WIP - fixing indentation)
Copilot Dec 13, 2025
bbabbdf
Add crash logging functionality to VideoWriter with tests
Copilot Dec 13, 2025
ae915e8
Address code review feedback - improve crash logging docs and tests
Copilot Dec 13, 2025
c6b32c6
Complete workflow verification and crash logging implementation
Copilot Dec 13, 2025
7a7523d
Final documentation improvements based on code review
Copilot Dec 13, 2025
8c57a0e
Merge pull request #208 from hackolite/copilot/update-video-stream-im…
hackolite Dec 13, 2025
9ed09cf
Initial plan
Copilot Dec 13, 2025
64bd98c
Remove timestamp-based ordering, use slot index instead
Copilot Dec 13, 2025
bd247d8
Add documentation for timestamp removal changes
Copilot Dec 13, 2025
553e336
Update test_video_writer_audio_slot_merge to use slot index ordering
Copilot Dec 13, 2025
207c39e
Fix docstring punctuation for consistency
Copilot Dec 13, 2025
b82a393
Merge pull request #209 from hackolite/copilot/remove-timestamp-depen…
hackolite Dec 13, 2025
d10cc35
Initial plan
Copilot Dec 13, 2025
488d50f
Implement stopping state logic for legacy mode video writer
Copilot Dec 13, 2025
a742c12
Address code review feedback: fix comment and add validation
Copilot Dec 13, 2025
db94ab4
Add implementation documentation
Copilot Dec 13, 2025
5ac4214
Refactor to address code review: extract finalization method, improve…
Copilot Dec 13, 2025
1c34512
Final improvements: extract magic numbers to constants, improve comme…
Copilot Dec 13, 2025
0da8131
Merge pull request #210 from hackolite/copilot/stop-audio-queue-on-stop
hackolite Dec 13, 2025
7812b9a
Initial plan
Copilot Dec 13, 2025
40269ef
Fix audio sample rate consistency from 22050 to 44100 Hz
Copilot Dec 13, 2025
c1217c3
Update spectrogram node sample rates to 44100 Hz
Copilot Dec 13, 2025
88ed0c6
Add backward compatibility alias for create_spectrogram_custom
Copilot Dec 13, 2025
842cd5b
Address code review feedback for parameter handling and comments
Copilot Dec 13, 2025
3c0d599
Improve docstring and fix n_fft default for test compatibility
Copilot Dec 13, 2025
24f7ff5
Simplify parameter precedence logic in create_spectrogram_custom
Copilot Dec 13, 2025
253e090
Add comprehensive documentation for audio sample rate fix
Copilot Dec 13, 2025
b0e6878
Merge pull request #212 from hackolite/copilot/fix-audio-sample-rate
hackolite Dec 13, 2025
e58cb1d
Initial plan
Copilot Dec 13, 2025
d017c66
Implement FPS-based audio chunking with 1:1 frame-to-chunk mapping
Copilot Dec 13, 2025
10c6780
Add comprehensive test for FPS-based audio chunking
Copilot Dec 13, 2025
d0d2e5b
Add comprehensive documentation for FPS-based audio chunking
Copilot Dec 13, 2025
2d45061
Improve fractional sample handling to avoid cumulative drift
Copilot Dec 13, 2025
cc5d408
Add validation test and implementation summary
Copilot Dec 13, 2025
adec489
Address code review feedback: use exact frame count and add deprecati…
Copilot Dec 13, 2025
d984da6
Merge pull request #213 from hackolite/copilot/add-audio-video-chunking
hackolite Dec 13, 2025
9b791c5
Initial plan
Copilot Dec 13, 2025
057a074
Remove Chunk Size and Queue Chunks sliders, add Start/Stop playback c…
Copilot Dec 13, 2025
bc237da
Update tests for slider removal - all tests passing
Copilot Dec 13, 2025
04ad507
Fix audio graininess by using proper rounding for chunk boundaries
Copilot Dec 13, 2025
f89c787
Address code review feedback - improve test assertions and validation…
Copilot Dec 13, 2025
a58762f
Add comprehensive implementation summary documentation
Copilot Dec 13, 2025
fd78147
Final code review feedback - improve test pattern matching specificity
Copilot Dec 13, 2025
69771e8
Simplify bounds checking logic in audio chunking
Copilot Dec 13, 2025
b17ec3c
Merge pull request #214 from hackolite/copilot/remove-slider-chunk-size
hackolite Dec 13, 2025
4851aba
Initial plan
Copilot Dec 13, 2025
aa5d417
Fix audio/video sync: add FFmpeg sync parameters and audio quality se…
Copilot Dec 13, 2025
a9f0060
Fix audio ahead of video and audio quality: add avoid_negative_ts par…
Copilot Dec 13, 2025
81311bb
Add comprehensive test and documentation for audio/video sync fix
Copilot Dec 13, 2025
6f546e7
Clarify shortest=None parameter documentation based on code review
Copilot Dec 13, 2025
894ad4f
Use direct parameter syntax for avoid_negative_ts per code review
Copilot Dec 13, 2025
ae6b953
Fix test logic for audio_bitrate parameter check
Copilot Dec 13, 2025
7ab669d
Merge pull request #215 from hackolite/copilot/fix-audio-video-sync-i…
hackolite Dec 13, 2025
d1e5610
Initial plan
Copilot Dec 14, 2025
66587c3
Fix audio/video desync by using detected video FPS instead of slider …
Copilot Dec 14, 2025
f8fb3fe
Update test_queue_size_uses_target_fps.py to test correct behavior
Copilot Dec 14, 2025
3af95fe
Add comprehensive documentation for FPS mismatch fix
Copilot Dec 14, 2025
f143c1e
Merge pull request #216 from hackolite/copilot/fix-audio-video-desync…
hackolite Dec 14, 2025
f556965
Initial plan
Copilot Dec 14, 2025
9979d82
Add VFR to CFR video conversion in video preprocessing
Copilot Dec 14, 2025
d02fec0
Add tests for VFR to CFR conversion functionality
Copilot Dec 14, 2025
713e067
Add comprehensive documentation for VFR to CFR conversion
Copilot Dec 14, 2025
880fb11
Address code review feedback - improve error handling and cross-platf…
Copilot Dec 14, 2025
39256db
Add security validations and improve code robustness
Copilot Dec 14, 2025
a6392b8
Final code polish - improve readability and reduce duplication
Copilot Dec 14, 2025
fafb4f2
Add implementation summary for VFR to CFR conversion
Copilot Dec 14, 2025
12d7760
Merge pull request #217 from hackolite/copilot/convert-vfr-to-cfr-video
hackolite Dec 14, 2025
a4208e3
Comment out FPS fallback logic in video metadata extraction
hackolite Dec 14, 2025
a23b435
Initial plan
Copilot Dec 14, 2025
08e70e3
Fix AVI video slow playback by re-encoding to H.264
Copilot Dec 14, 2025
9002da1
Add tests and documentation for AVI video fix
Copilot Dec 14, 2025
af84e50
Refactor test code to reduce duplication
Copilot Dec 14, 2025
4740b5b
Merge pull request #218 from hackolite/copilot/fix-slow-video-output
hackolite Dec 14, 2025
d3ef6b1
Initial plan
Copilot Dec 14, 2025
58fac81
Implement accurate FPS extraction using ffprobe to fix VFR audio sync…
Copilot Dec 14, 2025
ddb65f5
Update VFR documentation with references to audio sync fix
Copilot Dec 14, 2025
e83f332
Address code review feedback - improve validation and test maintainab…
Copilot Dec 14, 2025
e5cc694
Apply Pythonic improvements to FPS parsing and comments
Copilot Dec 14, 2025
3813543
Add comprehensive implementation summary for VFR audio fix
Copilot Dec 14, 2025
b3c1c81
Merge pull request #219 from hackolite/copilot/fix-video-audio-issues
hackolite Dec 14, 2025
1a4a8f7
Initial plan
Copilot Dec 14, 2025
9d5b9f3
Add audio priority workflow documentation and enhanced comments
Copilot Dec 14, 2025
d596e61
Address code review feedback - remove hard-coded line numbers and imp…
Copilot Dec 14, 2025
0f8079e
Add verification summary document
Copilot Dec 14, 2025
10e01d1
Merge pull request #222 from hackolite/copilot/check-audio-priority-i…
hackolite Dec 14, 2025
3e2cbf8
Initial plan
Copilot Dec 16, 2025
215b406
Add queue info display to input nodes (webcam, rtsp, microphone, yout…
Copilot Dec 16, 2025
71af199
Add queue info display to remaining input nodes (api, webrtc)
Copilot Dec 16, 2025
113620f
Refactor queue info display to shared utility method in basenode
Copilot Dec 16, 2025
c15bc7d
Optimize queue info updates - single call per update cycle in microph…
Copilot Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,7 @@ main_win64.spec
icon.ico
dist
build

# Logs directory
logs/
*.log.*
290 changes: 0 additions & 290 deletions ASYNC_MERGE_ARCHITECTURE.md
View file
Open in desktop

This file was deleted.

233 changes: 0 additions & 233 deletions AUDIO_MERGE_CRASH_FIX.md
View file
Open in desktop

This file was deleted.

Loading