Skip to content

HCK-14053: parse table properties in alter #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 2 commits into from
Dec 19, 2025
Merged

HCK-14053: parse table properties in alter #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64d8a6
HCK-14053: parse table properties in alter
AlikRakhmonov Dec 19, 2025
bb87693
fix
AlikRakhmonov Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions forward_engineering/hiveHelpers/helpers/alterScriptHelpers/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
const _ = require('lodash');

const commentPropKey = 'comment';

const getDifferentItems = (newItems = [], oldItems = []) => {
const intersection = _.intersectionWith(newItems, oldItems, _.isEqual);
return {
Expand All @@ -9,25 +11,30 @@ const getDifferentItems = (newItems = [], oldItems = []) => {
};

const hydrateTableProperties = ({ new: newItems, old: oldItems }, name, commentState) => {
const hydrateProperties = properties => (properties || '').split(',').map(prop => prop.trim());
const prepareProperties = properties =>
properties
.filter(Boolean)
.map(property => property.replace(/(\S+)=([\s\S]+)/, `'$1'='$2'`))
.map(property => `'${property.tablePropKey}'='${property.tablePropValue}'`)
.join(',\n');

const isCommentChanged = !_.isEqual(commentState?.new, commentState?.old);
const addCommentProp = isCommentChanged && commentState?.new ? `comment=${commentState?.new}` : '';
const dropCommentProp = isCommentChanged && !commentState?.new ? `comment` : '';

const addCommentProp =
isCommentChanged && commentState?.new
? { tablePropKey: commentPropKey, tablePropValue: commentState?.new }
: null;

const dropCommentProp = isCommentChanged && !commentState?.new ? { tablePropKey: commentPropKey } : null;

const preparePropertiesName = properties =>
properties
.filter(Boolean)
.map(prop => `'${prop.replace(/(=\S+)/, '')}'`)
.map(prop => `'${prop.tablePropKey}'`)
.join(', ');

const newHydrateItems = hydrateProperties(newItems);
const oldHydrateItems = hydrateProperties(oldItems);
// Ensure newItems and oldItems are arrays
const newHydrateItems = Array.isArray(newItems) ? newItems : [];
const oldHydrateItems = Array.isArray(oldItems) ? oldItems : [];

const { add, drop } = getDifferentItems(newHydrateItems, oldHydrateItems);

Expand Down