Enabled strict JSDoc usage and type highlights #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras-dubyk
reviewed
Mar 18, 2025
| * element. | ||
| * @returns {string} - The definition name. | ||
| */ | ||
| function getDefinitionNameFromReferencePath({ referencePath = '' }) { |
Contributor
There was a problem hiding this comment.
We got two identical files referenceHelper.js and referencesHelper.js.
It's worth removing one of them in this PR.
VitaliiBedletskyi
added
the
do not merge yet
VitaliiBedletskyi
removed
the
do not merge yet
|
taras-dubyk
approved these changes
Mar 19, 2025
taras-dubyk
added a commit
that referenced
this pull request
Apr 4, 2025
* HCK-10099: RE init (#85) * re from file init * fix linter * Added base logic for RE from GraphQL server (#87) * add entry point for RE from GraphQL server * reformat package.json * update title * fix sonarlint remark * HCK-10206: add directives RE (#86) * add directives RE * add tests for directives definitions mapping * add tests for directives usage * fix remarks * HCK-10331: add custom scalars RE (#89) * add custom scalars RE * fix mapping directive argument value * update tests * add custom scalars RE tests * add directive prefix * fix package of plugin (#90) * Enabled strict JSDoc usage and type highlights (#91) * move types to centralized place and add prettier and eslint for them * add type check using typescript * disable multiline JSDoc * align types and eslint with latest changes * update unit test * delete duplicated file * Add strict types check (#92) * align types and fix all type related issues * enable types validation on pre-push git hook * add custom rule to restrict ambiguous types in @return tag * align types with more strict rules * remove redundant type * reconcile type names * reconcile some RE types * fix name of parameters in enum mapper * HCK-10332: RE Enum types (#93) * implement parsing of Enum types * add unit tests * add prettier for TS files * remove console.log * HCK-10333: add object type definitions RE (#94) * add object types RE * update types * add field mapper tests * add object type tests * move field mapper test for consistent files structure * update types * update types * add RE of interfaces (#95) * HCK-10335: add RE of input types definitions (#96) * add input types RE * fix linter warning * fix types * add root types RE (#98) * HCK-10473: add arguments mapping for RE (#99) * add arguments mapping for RE * add arguments mapping tests * add unions RE (#97) * Fix running unit tests with node22 (#101) * add schema validation during RE (#102) * HCK-10653: fix fallback type name (#103) * fix fallback type name * update test * HCK-10661: Improve error handling for RE from file (#104) * improve error handling * refactor * HCK-10657: finalize RE from instance (#105) * HCK-10657: finalize RE from instance * fix progress messages * remove type import * fix type * fix types --------- Co-authored-by: Vitalii Bedletskyi <70570504+VitaliiBedletskyi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
shared/typestsconfig.jsonto check JS modules with proper type usage (NOT REQUIRED but recommended) - preparation for using strict checksnpm run check:typesnpm command to check types in the codebaserevers_engineeringfolder....