Skip to content

HCK-11272: improve FE performance #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 2 commits into from
May 23, 2025
Merged

HCK-11272: improve FE performance #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39974a
disable fields sorting and JSON doc generation to improve FE perf
taras-dubyk May 23, 2025
718daa2
handle missed definition with fallback type
taras-dubyk May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion forward_engineering/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@
"model": false
},
"mode": "graphqlschema",
"isApiSchema": false
"isApiSchema": false,
"disableJSONDataGeneration": true,
"disableAttributesSorting": true
}
2 changes: 1 addition & 1 deletion forward_engineering/mappers/fields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function mapField({ name, fieldData, required, definitionsIdToNameMap, addArgume
*/
function getFieldType({ field, required }) {
if ('$ref' in field && field.$ref) {
const definitionName = getDefinitionNameFromReferencePath({ referencePath: field.$ref });
const definitionName = getDefinitionNameFromReferencePath({ referencePath: field.$ref }) || 'String';
return addRequired({ type: definitionName, required });
}

Expand Down
8 changes: 6 additions & 2 deletions reverse_engineering/helpers/getDefinitionCategoryByNameMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,18 @@ const kindToDefinitionTypeName = {
*
* @param {object} options
* @param {DefinitionNode[]} options.nodes - The nodes to search
* @param {string[]} options.rootTypeNames - The root type names to exclude
* @returns {DefinitionNameToTypeNameMap} The found nodes with proper type
*/
function getDefinitionCategoryByNameMap({ nodes }) {
function getDefinitionCategoryByNameMap({ nodes, rootTypeNames }) {
return nodes
.filter(node => kindToDefinitionTypeName[node.kind])
.reduce((acc, node) => {
if ('name' in node && node.name !== undefined) {
acc[node.name.value] = kindToDefinitionTypeName[node.kind];
const isRootType = rootTypeNames.includes(node.name.value);
if (!isRootType) {
acc[node.name.value] = kindToDefinitionTypeName[node.kind];
}
}
return acc;
}, {});
Expand Down
2 changes: 1 addition & 1 deletion reverse_engineering/mappers/schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function getMappedSchema({ schemaItems, graphName, fieldsOrder }) {
container.schemaRootTypes?.rootSubscription || 'Subscription',
];

const definitionCategoryByNameMap = getDefinitionCategoryByNameMap({ nodes: schemaItems });
const definitionCategoryByNameMap = getDefinitionCategoryByNameMap({ nodes: schemaItems, rootTypeNames });

const rootTypeNodes = findNodesByKind({
nodes: schemaItems,
Expand Down