Skip to content

HCK-11251: improved escaping logic to prevent last ip portion being confused with port #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vitalii4as merged 1 commit into from
May 22, 2025
Merged

HCK-11251: improved escaping logic to prevent last ip portion being confused with port #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions reverse_engineering/helpers/escapeV6IpForURL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ const ip = require('ip');
*/
function escapeV6IpForURL({ host }) {
/**
* If the host is already URL compatible then the ip lib will return false > ip.isV6Format('[::1]') false If the host
* is a proper ipv6 ip then the `new URL(host)` will fail with Uncaught TypeError: Invalid URL code:
* 'ERR_INVALID_URL', !ip.isV4Format(host) check required because isV6Format returns true for ipv4 address because of
* backward compatibility
* If the host is already URL compatible then the ip lib will return false > ip.isV6Format('[::1]') false If the
* host is a proper ipv6 ip then the `new URL(host)` will fail with Uncaught TypeError: Invalid URL code:
* 'ERR_INVALID_URL', !ip.isV4Format(host) check required because isV6Format returns true for ipv4 address because
* of backward compatibility
*/
if (ip.isV6Format(host) && !ip.isV4Format(host)) {
return `[${host}]`;
return escapeHost(host);
}

const isUrlValid = isValidURL(host);
Expand All @@ -42,7 +42,20 @@ function escapeV6IpForURL({ host }) {
const port = separatedIpPortionsAndPort.at(-1);
const escapedIpWithPort = `[${ipPortions.join(':')}]:${port}`;

return host.replace(unescapedIpWithPort, escapedIpWithPort);
const hostWithEscapedAllPortionsButTheLastOne = host.replace(unescapedIpWithPort, escapedIpWithPort);
if (isValidURL(hostWithEscapedAllPortionsButTheLastOne)) {
return hostWithEscapedAllPortionsButTheLastOne;
}

return host.replace(unescapedIpWithPort, escapeHost(unescapedIpWithPort));
}

/**
* @param {string} host
* @returns {string}
*/
function escapeHost(host) {
return `[${host}]`;
}

/**
Expand Down