-
-
Notifications
You must be signed in to change notification settings - Fork 844
Dynamically Created Pages for each Program Area Using a Layout #8437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
…program-area-layout-3328
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 8 PM 11/28/25 |
|
Review ETA: 6 PM 11/28/25 |
TheManTheMythTheGameDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ldaws003! Great job on this PR:
- Branches are correct
- Changes look great -- all the new pages are accurate and complete
- Changes are clean and effective
I will say I was a little surprised to see that the problem/solution text does not appear for any projects outside of Citizen Engagement -- but upon closer inspection, this was not an issue with your implementation, and the text remains to be written.
The program area page template makes references to the citizen engagement header SVG and the citizen engagement JS logic, but it seems like these should remain constant for all program area pages, so I think it's fine.
Great job -- approved!
santi-jose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job working on this issue @ldaws003 !
What you did well:
- Made pull request with correct branches
- Linked your issue
- Made code changes requested by issue
- Maintained integrity of website with changes in code
- Program area pages properly render
Great work! I have no changes to suggest and approve this PR.
|
Review ETA: 12/6/2025 |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done Well
- Good detailed explanations of changes.
- Good job on asking questions for clarification.
Things to Address
-
There is a bug when viewing the program areas webpages in smaller widths. For example, on the Citizen Engagement webpage, the Sustainable Development Goal components for the project cards have their texts cut off in mobile widths and have their texts in narrow columns in tablet widths.
This issue might be out of scope, but I would like to see at least a resolution or clarification with the issue author. Ideally, you could create an Emergent Request to have this fixed.
-
Under the todo item
In each project's Markdown file in _projects directory, there is a field called visible. If visible is true, then the project should show up on the program area page(s) it falls under. If visible is false, then the project should not show up.
, changing the
visibleproperties do not do anything. For example, changing 311 Data's or Open Community Survey's visibilities do not do anything.I assume this action item is outdated or inaccurate as the visible property might have some other purpose, but this should be clarified with the issue author. Else, you would need to do some digging to figure this out.
|
Hi @myronchen-git, Thanks for taking a look. I'll bring the issue with the text being cut off in Sustainability Goal with the issue creator. For the visibility property. It does work on my end. For me it the effects of changing that only shows after stopping and restarting docker-compose. |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my two points. And thanks for the explanation on stopping and starting Docker. That got the visibility to work. Everything else is in order and you followed the instructions well.


Fixes #3328
What changes did you make?
citizen-engagement.htmltoprogram-area-pages.htmlprogram-area-pages.htmlto the_layoutsfolderprogram-area-pages-cards.htmlto filter for visible projects that are part of the page's program area_citizen_engagement.scssto_program-area-pages.scss_citizen_engagement.scssin_sass/main.scssto_program-area-pages.scssWhy did you make the changes (we will use this info to test)?
citizen-engagement.htmlwas renamed toprogram-area-pages.htmland moved to_layoutsto create a reusable layout to generate pages for other program areasprogram-area-pages-cards.htmlwas modified to make it dynamically work for any program areas_citizen_engagement.scsswas renamed and it's import updated to reflect the name change of thecitizen-engagement.htmlpageCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied