Skip to content

Fix bug regarding the copy feature #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KisuHypee merged 2 commits into from
Apr 6, 2026
Merged

Fix bug regarding the copy feature #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
601f57a
Fix course card leading to wrong course
JuneMinazuki Apr 6, 2026
289a09b
Fix goBack() error
JuneMinazuki Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion app/javascript/controllers/overlay_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default class extends Controller {
}

selectSetting(event) {
const sourceCourseId = event.params.courseId;
const sourceCourseId = event.params.sourceId;
const targetCourseId = this.targetCourseIdValue;
const mode = this.modeValue;

Expand Down Expand Up @@ -137,4 +137,20 @@ export default class extends Controller {

this.close(event);
}

goBack(event) {
if (event) event.preventDefault();
this.returnToList();
}

returnToList() {
this.containerTarget.removeAttribute("src");
this.containerTarget.removeAttribute("complete");

if (this.initialContent) {
this.containerTarget.innerHTML = this.initialContent;
} else {
this.containerTarget.innerHTML = "";
}
}
}
2 changes: 1 addition & 1 deletion app/views/courses/_copy_course_overlay.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<% if @courses.present? %>
<div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-8">
<% @courses.each do |course_item| %>
<div data-overlay-target="card" data-action="click->overlay#selectSetting" data-overlay-course-id-param="<%= course.id %>"
<div data-overlay-target="card" data-action="click->overlay#selectSetting" data-overlay-source-id-param="<%= course_item.id %>"
class="h-full min-h-[240px] bg-white rounded-xl border border-gray-200 p-8 transition-all duration-200 ease-in-out hover:border-green-400 hover:shadow-md flex flex-col justify-between cursor-pointer">
<div>
<div class="flex items-start justify-between mb-2">
Expand Down
Loading