Conversation
There was a problem hiding this comment.
💡 Codex Review
codex-extended/codex-rs/lmstudio/src/lib.rs
Lines 167 to 191 in 41a7e2a
[P1] Readiness check misses LM Studio models with quantization suffixes
The model_available probe only considers a model present when id, name, or model exactly match the canonical identifier or end with the short name. LM Studio’s /v1/models responses commonly append quantization info to the identifier (e.g. Meta-Llama-3.1-8B-Instruct-Q4_0). Such IDs neither equal the canonical value nor end with it, so ensure_lmstudio_ready will error even when the requested model is installed, preventing the CLI/TUI from starting. Consider matching by substring or prefix rather than strict equality/ends_with to accept IDs with additional suffixes.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Summary
codex-lmstudiocrate with alias resolution, readiness checks, and default model wiringTesting
cargo test -p codex-lmstudiocargo test -p codex-exec --test all suite::lmstudio::exec_resolves_lmstudio_model_aliases -- --test-threads=1cargo test -p codex-tuihttps://chatgpt.com/codex/tasks/task_b_68d7b97a01c4832f838e912807a17559