Add option to copy iptc data when transplanting exif information#112
Open
sandrinewitt wants to merge 1 commit intohMatoba:masterfrom
Open
Add option to copy iptc data when transplanting exif information#112sandrinewitt wants to merge 1 commit intohMatoba:masterfrom
sandrinewitt wants to merge 1 commit intohMatoba:masterfrom
Conversation
MRigal
suggested changes
Nov 20, 2020
| def test_transplant_with_iptc_data(self): | ||
| piexif.transplant(INPUT_FILE1, INPUT_FILE_PEN, "transplant.jpg", include_iptc=True) | ||
| i = Image.open("transplant.jpg") | ||
| i.close() |
There was a problem hiding this comment.
do you still need to open and close it?
| self.assertEqual( | ||
| _common.get_iptc_seg(original_segments), | ||
| _common.get_iptc_seg(copy_segments) | ||
| ) |
There was a problem hiding this comment.
Maybe you could make sure that these are not equal before calling transplant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the possibility to include iptc data when using transplant on images #111.
Iptc data stores additional non-graphic information for images (e.g. description, keywords).