Skip to content

Conversation

@joao-imi
Copy link
Contributor

@joao-imi joao-imi commented Nov 25, 2025

Adds a delay to the retry mechanism in order to deal with latent network issues, allowing the network to potentially recover in-between retries.

This pull request also adds the ability for the implementer to configure the delay time and the amount of retries.

@joao-imi joao-imi self-assigned this Nov 25, 2025
@brdlyptrs brdlyptrs changed the title fix(retry) feat(retry): Add delay and configuration parameters to retry Nov 25, 2025
@joao-imi joao-imi requested a review from brdlyptrs November 26, 2025 00:39
@joao-imi joao-imi requested a review from brdlyptrs November 26, 2025 11:32
zoryana94
zoryana94 previously approved these changes Nov 26, 2025
Copy link

@zoryana94 zoryana94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working! 👍
1s delay by default may be not enough in case of the network-error
as we'll have it customizable, it's pretty good

@brdlyptrs
Copy link
Contributor

@joao-imi please upgrade the version number in the package.json

@brdlyptrs brdlyptrs marked this pull request as ready for review November 26, 2025 17:18
@brdlyptrs brdlyptrs requested review from a team as code owners November 26, 2025 17:18
@joao-imi
Copy link
Contributor Author

fbf8bba

Just bumped here: fbf8bba

@joao-imi joao-imi requested a review from zoryana94 November 26, 2025 17:30
@joao-imi joao-imi merged commit dd6e216 into main Nov 26, 2025
3 checks passed
@joao-imi joao-imi deleted the fix-retry-cleanup branch November 26, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants