-
Notifications
You must be signed in to change notification settings - Fork 12
feat(retry): Add delay and configuration parameters to retry #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+59
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdlyptrs
reviewed
Nov 25, 2025
brdlyptrs
reviewed
Nov 26, 2025
zoryana94
previously approved these changes
Nov 26, 2025
zoryana94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working! 👍
1s delay by default may be not enough in case of the network-error
as we'll have it customizable, it's pretty good
Contributor
|
@joao-imi please upgrade the version number in the package.json |
Contributor
Author
brdlyptrs
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a delay to the retry mechanism in order to deal with latent network issues, allowing the network to potentially recover in-between retries.
This pull request also adds the ability for the implementer to configure the delay time and the amount of retries.