Fix: make echo360.js work in strict mode#158
Open
mindcrunch4u wants to merge 1 commit intoh5p:masterfrom
Open
Conversation
Root Cause: "delete" doesn't work on a variable declared with "let". Changes: Assigning the variable "undefined" has the same effect, and this will work in strict mode. According to [the doc](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Delete_in_strict_mode): > Normal variables in JavaScript can't be deleted using the delete operator. In strict mode, an attempt to delete a variable will throw an error and is not allowed. This is affecting h5p users, for example, see [this issue](Lumieducation/H5P-Nodejs-library#4197).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause:
"delete" doesn't work on a variable declared with "let".
Changes:
Assigning the variable "undefined". This has the same effect, and should work in strict mode.
According to the doc:
This is affecting h5p users, for example, see this issue.
According to git blame, cc: @otacke