HFP-4221 Fix default text track is not selected properly#338
Open
otacke wants to merge 8 commits intoh5p:masterfrom
Open
HFP-4221 Fix default text track is not selected properly#338otacke wants to merge 8 commits intoh5p:masterfrom
otacke wants to merge 8 commits intoh5p:masterfrom
Conversation
Also allows to set no default track and to let default track be selected based on browser language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, will ensure the selected default caption track will be activated.
Also allows the editor to not let a caption track be loaded by default and to let the default track be picked automatically based on the browser language or preferred language.
Bonus #1: Fixes translation files that were invalid.
Bonus #2: Makes the "Off" label in the caption selector translateable instead of using a hardwired string.