Update hint regarding open bookmarks menu on ipad#237
Open
otacke wants to merge 1 commit intoh5p:masterfrom
Open
Update hint regarding open bookmarks menu on ipad#237otacke wants to merge 1 commit intoh5p:masterfrom
otacke wants to merge 1 commit intoh5p:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hint (from 2016) that the bookmarks menu will not show when opening an interactive video on an iPad that is hosted on YouTube is outdated. It's working fine since Safari 13 (September 2019).
When merged in, the hint will be updated accordingly. While H5P strives to support the latest three versions of browsers, Apple devices are used for quite a while and some may not be able to run Safari 13 anymore, so the hint was not removed completely.