HFP-3870 Prevent crash if H5P Integration does not provide file icon#209
Open
otacke wants to merge 1 commit intoh5p:masterfrom
Open
HFP-3870 Prevent crash if H5P Integration does not provide file icon#209otacke wants to merge 1 commit intoh5p:masterfrom
otacke wants to merge 1 commit intoh5p:masterfrom
Conversation
otacke
force-pushed
the
fix-file-icon
branch
from
56aa226 to
03e773f
Compare
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, will prevent the editor from crashing if a "binary" file (e.g. VTT file) is uploaded and the H5P integration does not set H5PIntegration.editor.fileIcon properly (as the H5P CLI server currently).