HFP-3673 Hide fullscreen button for video/DQ of all Columns#63
Open
otacke wants to merge 1 commit intoh5p:masterfrom
Open
HFP-3673 Hide fullscreen button for video/DQ of all Columns#63otacke wants to merge 1 commit intoh5p:masterfrom
otacke wants to merge 1 commit intoh5p:masterfrom
Conversation
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, the fullscreen button of "Video" instances and "Drag Question" instances will be hidden for all "Column" instances, not only for Interactive Book.
Background: The fullscreen button on Column subcontent can create a weird user experience. While sending "Video" to fullscreen seems to work on Chrome, iOS is known to cause trouble and only sending some subcontent to fullscreen may be confusing at times. Sending "Drag Question" to fullscreen even crashes.
The current implementation feels like a hot fix And if the change that's done was limited to Interactive Book intentionally, one would expect those extra CSS classes in the code of Interactive Book instead, not here in Column.