Skip to content

Validate required bootloader fields before dictionary access #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2zero merged 3 commits into from
Jan 21, 2026
Merged

Validate required bootloader fields before dictionary access #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec2d2bc
Initial plan
Copilot Jan 21, 2026
52f578b
Add validation for required bootloader fields
Copilot Jan 21, 2026
93e7d7d
Fix code style - adjust spacing
Copilot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions builder/frameworks/arduino/nrf5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,15 @@
env.Exit(1)

if selected_bl:
# Validate required bootloader fields
required_fields = ["bootloader_file", "linker_script", "max_size", "max_ram_size"]
missing_fields = [field for field in required_fields if field not in selected_bl]
if missing_fields:
sys.stderr.write(
"Error. Bootloader '%s' is missing required fields: %s\n" %
(selected_bl.get("name", "unknown"), ", ".join(missing_fields)))
env.Exit(1)

# Use bootloader_file, linker_script, max_size, max_ram_size from selected_bl
env.Replace(BOOTLOADERHEX=join(FRAMEWORK_DIR, "variants", board.get("build.variant", ""), selected_bl["bootloader_file"]))
if "flags" in selected_bl:
Expand Down