Conversation
h2zero
force-pushed
the
dev
branch
3 times, most recently
from
021f830 to
64a5e2b
Compare
h2zero
force-pushed
the
dev
branch
4 times, most recently
from
cdfe371 to
83e8d51
Compare
There was a problem hiding this comment.
Pull request overview
This pull request refactors the bootloader configuration system to use a more flexible array-based structure instead of a dictionary, allowing multiple bootloader options per board. The PR removes explicit bootloader selections from example configurations and adds support for the Seeed XIAO nRF52840 Sense board.
Changes:
- Refactored bootloader configuration from dictionary to array format in board JSON files, enabling multiple bootloader options per board
- Updated Python build script to iterate through bootloader arrays and apply selected bootloader settings
- Removed hardcoded
board_bootloadersettings from example platformio.ini files, relying on default bootloader selection
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 46 comments.
Show a summary per file
| File | Description |
|---|---|
| builder/frameworks/arduino/nrf5.py | Updated bootloader handling logic to work with array structure and added default bootloader selection |
| boards/*.json (multiple) | Converted bootloader configs from dict to array format, added bootloader options with detailed parameters |
| examples/BLE-server-test/platformio.ini | Removed explicit board_bootloader settings, added seeed_xiao_nrf52840_sense board |
| examples/BLE-client-test/platformio.ini | Removed explicit board_bootloader settings, added seeed_xiao_nrf52840_sense board |
| .github/workflows/examples.yml | Updated workflow triggers to specific branches and updated actions/checkout version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.