Refactor envconfig for idiomatic Go and extensibility #4
Conversation
- Introduced public `Source` interface to allow custom configuration sources. - Refactored `Set` to support multiple sources cleanly. - Replaced `flag.Parse()` call with a check to avoid side effects. - Unified struct population logic into `populateStructRecursive`. - Removed `github.com/google/go-cmp` dependency. - Updated tests to use `t.Setenv` for better isolation. - Fixed `WithPrefix` option usage.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Refactored the library to improve extensibility and follow idiomatic Go patterns. Key changes include:
Sourceinterface tosource.goand implementedFlagSource,EnvironmentVariableSource, andFileSource.Setto iterate over sources dynamically.envconfig.goto use recursion for nested structs, simplifying the logic.go-cmpto keep the library dependency-free.t.Setenv.WithFilepath.PR created automatically by Jules for task 15701221407994544591 started by @h-dav