-
Notifications
You must be signed in to change notification settings - Fork 7
docs: enhance documentation UX and visual hierarchy #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: enhance documentation UX and visual hierarchy #25
Conversation
- Update component styling for better consistency - Remove redundant documentation components - Improve spacing and typography - Fix icon alignment issues
gzuuus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pr, there are couple issues to solve before we can get this merged, but good one! 🤙
src/routes/docs/+page.svelte
Outdated
| @@ -1,14 +1,190 @@ | |||
| <script lang="ts"> | |||
| import InfoDialog from "$lib/components/info-dialog.svelte"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to remove the unused imports, since InfoDialog contains two imports that doesn't exist any more, and that break the docs page
import DocNewList from "$lib/docsComponents/doc-new-list.svelte";
import DocOldLists from "$lib/docsComponents/doc-old-lists.svelte";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noob errors on my part ... thank you for the catch / review.
src/routes/docs/+page.svelte
Outdated
| <hr class="my-8"> | ||
|
|
||
| <section class="mb-12"> | ||
| <h2 class="text-2xl md:text-3xl font-semibold mb-4 mt-8">Migrating Old Lists</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section Migrating Old Lists Doesn't make too much sense, there are no import option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake ... originally I'd been experimenting with an idea related to adding language localization etc. which evolved into NIP-74... I forgot to remove that bit ...
- Remove migration section as it's not currently implemented - Simplify documentation flow - Focus on core features
- Remove unused imports - Remove unused components - Simplify dialog implementation - Clean up styling
- Remove default export attempt (not needed in Svelte) - Fix type issues by making props required with defaults - Clean up component structure
|
fixed the bug preventing login as well. I missed a couple of IDE errors that I only caught after testing it locally. Got a bit ahead of myself & excited to contribute. |


Key Improvements:
Visual Updates:
These changes make the documentation more professional, easier to navigate, and maintain consistency with Nostree's design system.