Skip to content

fix: close chrome page on throw #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzukas merged 1 commit into from
Feb 12, 2025
Merged

fix: close chrome page on throw #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/src/routes/screenshots/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default async function screenshots(options: ScreenshotsOptions) {
});
return { browser };
})
.onAfterHandle(({ browser }) => browser.disconnect())
.onAfterResponse(({ browser }) => browser?.disconnect())
.get(
'/:url',
async ({ params: { url }, query, browser }) => {
Expand Down
27 changes: 14 additions & 13 deletions apps/api/src/routes/screenshots/takeScreenshots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,19 @@ export async function* takeScreenshots(
) {
const { deviceType = 'desktop', colorSchemes = ['dark', 'light'] } = options;
const page = await browser.newPage();
await page.emulate(deviceMapping[deviceType]);

for (const colorScheme of colorSchemes) {
await page.emulateMediaFeatures([
{ name: 'prefers-color-scheme', value: colorScheme }
]);
await page.goto(url, { waitUntil: 'networkidle0' });
const screenshot = await page.screenshot({
type: 'webp'
});
yield [colorScheme, new Blob([screenshot])] as const;
try {
await page.emulate(deviceMapping[deviceType]);
for (const colorScheme of colorSchemes) {
await page.emulateMediaFeatures([
{ name: 'prefers-color-scheme', value: colorScheme }
]);
await page.goto(url, { waitUntil: 'networkidle0' });
const screenshot = await page.screenshot({
type: 'webp'
});
yield [colorScheme, new Blob([screenshot])] as const;
}
} finally {
await page.close();
}

await page.close();
}