WIP: A/B Update improvements #563
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying images while initializing the A/B update mechanism failes, the potentially corrupted copy should be cleaned up. This ensures that in case of failure (e.g. EFI partition too small to hold two kernel images) no corrupted copy takes up all space and we are not able to load another update. Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
Align return types in header with implementation. Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
Like for file_copy, check if initializing efivars was successful and abort if initialization failed. Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
quitschbo
reviewed
Jan 7, 2026
| efivars_set_boot_order((uint16_t[]){ 0000, 0001 }, 2); | ||
| int ret = 0; | ||
|
|
||
| ret = efivars_set_boot_entry(0, "GyroidosA", "\\EFI\\BOOT\\" DEFAULT_KERNEL_BINARY ".A"); |
Member
There was a problem hiding this comment.
putting this in the IF_TRUE_RETVAL parenthesis will generate a more meaningful log message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be improved/discussed: