address issue where when all 256 symbols are used then num_active mus…#1
Open
mdejong wants to merge 1 commit intogyaikhom:masterfrom
Open
address issue where when all 256 symbols are used then num_active mus…#1mdejong wants to merge 1 commit intogyaikhom:masterfrom
mdejong wants to merge 1 commit intogyaikhom:masterfrom
Conversation
…t be special cases to 256 instead of zero, fix int representation so that negative index value is generated when more than 127 symbols are used
Author
|
Here is a script that generates a file that contains all 256 symbols, this can be used to test the patch. cat write_bytes.tcl for {set i 0} {$i < 256} {incr i} { puts "wrote all bytes" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t be special cases to 256 instead of zero, fix int representation so that negative index value is generated when more than 127 symbols are used