Skip to content

address issue where when all 256 symbols are used then num_active mus…#1

Open
mdejong wants to merge 1 commit intogyaikhom:masterfrom
mdejong:master
Open

address issue where when all 256 symbols are used then num_active mus…#1
mdejong wants to merge 1 commit intogyaikhom:masterfrom
mdejong:master

Conversation

@mdejong
Copy link
Copy Markdown

@mdejong mdejong commented Nov 10, 2017

…t be special cases to 256 instead of zero, fix int representation so that negative index value is generated when more than 127 symbols are used

…t be special cases to 256 instead of zero, fix int representation so that negative index value is generated when more than 127 symbols are used
@mdejong
Copy link
Copy Markdown
Author

mdejong commented Nov 10, 2017

Here is a script that generates a file that contains all 256 symbols, this can be used to test the patch.

cat write_bytes.tcl
set outfd [open "all_bytes.bin" "w"]
fconfigure $outfd -encoding binary -translation binary

for {set i 0} {$i < 256} {incr i} {
set c [binary format c $i]
puts -nonewline $outfd $c
puts "wrote byte value $i"
}

puts "wrote all bytes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant