Switch build from SQLite to DuckDB for penguins DB#7
Open
Pavan0277 wants to merge 1 commit intogvwilson:mainfrom
Open
Switch build from SQLite to DuckDB for penguins DB#7Pavan0277 wants to merge 1 commit intogvwilson:mainfrom
Pavan0277 wants to merge 1 commit intogvwilson:mainfrom
Conversation
Pavan0277
commented
Aug 14, 2025
- Replace sqlite3 CLI with duckdb in common.mk for in-repo query targets.
- Add create_penguins_duckdb.py to generate DuckDB-format db/penguins.db.
- command in ./Makefile that generates db/penguins.db
Author
|
Hi @gvwilson, could you please review this PR when you get a chance and merge it if everything looks good? Thanks! |
Owner
|
Thanks @Pavan0228 - I'll try it out and leave feedback this week. |
Owner
|
Hi @Pavan0228 - after looking through this and thinking about how many other things would have to change, I've decided to stick with SQLite for now, and to create another short lesson on DuckDB similar to the one on PostgreSQL. I'll keep this PR open for reference, and may merge it into the branch where I do the DuckDB lesson so that your contribution shows up in the Git history. Thanks again for creating it - I appreciate it a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.