Refactor/e2e data test id and factory defaults#15
Merged
Conversation
- Add data-test-id to custom and base props in renderer orchestrator - Use FormSchema type in resolveSpec and remove unused getComponentRegistry import
…components - Spread data-test-id and externalContext in FormField and all Default* components - Forward data-test-id in field-renderer wrapper props - Remove hardcoded data-test-id in favor of orchestrator-injected value
- Remove local FormField, FormSection*, InputCheckbox, InputDate, InputNumber, InputSelect, InputTextarea - Simplify ComponentRegistry to InputText only; form/container components use factory defaults - Update FormWithFormik, FormWithRHF and form containers accordingly
- Target input, select, textarea by tag with data-test-id for reliable selection - Handle InputSelect and InputTextarea in fill and assertion logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.