Fix/container props and test improvements#10
Merged
Conversation
Container renderer now merges x-component-props before sanitizing, allowing components like FormField to receive props from schema. This matches the behavior of field renderer for consistency.
Add extractFormFields and extractRequiredFields functions to extract field names and required fields from form schemas. This enables dynamic test validation based on schema definitions.
- Update tests to use extracted fields from JSON schemas - Fix select field interaction using selectOption instead of fill - Simplify test structure and remove redundant assertions - Update Playwright config for better test organization
Remove Chakra UI, Material UI, and provider-specific test files as they are no longer needed in the current test structure.
Clean up container components by removing debugger statements from FormField, FormSectionContainer, FormSectionGroup, FormSectionGroupContainer, and FormSectionTitle components.
- Update complex-form.json structure - Refine schema type definitions - Adjust form page layout and styling - Improve CSS organization
Change InputCheckbox components in Chakra UI and Material UI to use the standard 'value' prop instead of 'checked' for consistency with other input components and the form adapter API.
- Remove GridItem wrapper in Chakra UI version - Replace Grid container/item pattern with Box in Material UI version - Use CSS Grid directly for simpler layout - Add data-test-id attribute for better testability - Maintain same visual layout with cleaner code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.