Updated to use new MongoClient by jacaetevha · Pull Request #4 · guyboertje/jmongo

jacaetevha · 2012-11-29T21:50:53Z

Please take a look. I didn't spend a lot of time on this. And I only tested it against the specs you already had (which isn't very extensive). Seems to work fine.

guyboertje · 2012-11-30T18:39:48Z

Thanks for taking time to do that. My only concern is that my patched version of the jar included support for Ruby Symbols. Over a year ago I created a JIRA JAVA-441 ticket to add it to the java driver but nothing was done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you interested in taking over this project?

jacaetevha · 2012-11-30T20:07:19Z

sure... I'll take it over

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje notifications@github.comwrote:

Thanks for taking time to do that. My only concern is that my patched
version of the jar included support for Ruby Symbols. Over a year ago I
created a JIRA JAVA-441 ticket to add it to the java driver but nothing was
done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you
interested in taking over this project?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10899256.

jacaetevha · 2012-12-03T16:54:16Z

How important is JAVA-441? Certainly we can get along with just strings.
Right?

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje notifications@github.comwrote:

Thanks for taking time to do that. My only concern is that my patched
version of the jar included support for Ruby Symbols. Over a year ago I
created a JIRA JAVA-441 ticket to add it to the java driver but nothing was
done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you
interested in taking over this project?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10899256.

guyboertje · 2012-12-03T20:22:26Z

The ruby driver supports deserializing symbols and so I wanted to try to
maintain as much compatibility with the ruby driver as possible. I have
sent a Pull Request to the java driver repo - but I suspect that they have
no real way of field testing the change so they might not pull it. Is it
important - I dunno, but the 1.1.5 gem that some people may be using does
support symbols. How is your java fu? If you have a working up to date
java tool chain in place, (I remeber it was a bit of a hassle to get the
jar compiled) you could just keep changing the BasicBSONCallback.java file,
compiling it and pushing it into the jar.

Have you looked at the Moped driver?

Guy

On Mon, Dec 3, 2012 at 4:54 PM, Jason Rogers notifications@github.comwrote:

How important is JAVA-441? Certainly we can get along with just strings.
Right?

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje notifications@github.comwrote:

Thanks for taking time to do that. My only concern is that my patched
version of the jar included support for Ruby Symbols. Over a year ago I
created a JIRA JAVA-441 ticket to add it to the java driver but nothing
was
done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you
interested in taking over this project?

—
Reply to this email directly or view it on GitHub<
https://github.com/guyboertje/jmongo/pull/4#issuecomment-10899256>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10961155.

jacaetevha · 2012-12-03T20:52:52Z

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

On Mon, Dec 3, 2012 at 3:22 PM, Guy Boertje notifications@github.comwrote:

The ruby driver supports deserializing symbols and so I wanted to try to
maintain as much compatibility with the ruby driver as possible. I have
sent a Pull Request to the java driver repo - but I suspect that they have
no real way of field testing the change so they might not pull it. Is it
important - I dunno, but the 1.1.5 gem that some people may be using does
support symbols. How is your java fu? If you have a working up to date
java tool chain in place, (I remeber it was a bit of a hassle to get the
jar compiled) you could just keep changing the BasicBSONCallback.java
file,
compiling it and pushing it into the jar.

Have you looked at the Moped driver?

Guy

On Mon, Dec 3, 2012 at 4:54 PM, Jason Rogers notifications@github.comwrote:

How important is JAVA-441? Certainly we can get along with just strings.
Right?

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje notifications@github.comwrote:

Thanks for taking time to do that. My only concern is that my patched
version of the jar included support for Ruby Symbols. Over a year ago
I
created a JIRA JAVA-441 ticket to add it to the java driver but
nothing
was
done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you
interested in taking over this project?

—
Reply to this email directly or view it on GitHub<
https://github.com/guyboertje/jmongo/pull/4#issuecomment-10899256>.

—
Reply to this email directly or view it on GitHub<
https://github.com/guyboertje/jmongo/pull/4#issuecomment-10961155>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10969875.

guyboertje · 2012-12-03T22:37:40Z

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers notifications@github.comwrote:

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

jacaetevha · 2012-12-03T22:46:26Z

Do you know of any benchmark suites for it?

Jason Rogers

On Mon, Dec 3, 2012 at 5:37 PM, Guy Boertje notifications@github.comwrote:

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers <notifications@github.com

wrote:

My Java fu is fine, though I don't want to have to support a modified
JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

—

Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10975597.

guyboertje · 2012-12-04T09:53:04Z

no - but I suspect the one that Chuck Remes built to benchmark his first
version of jmongo would work. I think he deleted ithe github repo though.
I might have a copy locally. I will look tonight.

On Mon, Dec 3, 2012 at 10:46 PM, Jason Rogers notifications@github.comwrote:

Do you know of any benchmark suites for it?

Jason Rogers

On Mon, Dec 3, 2012 at 5:37 PM, Guy Boertje notifications@github.comwrote:

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers <notifications@github.com

wrote:

My Java fu is fine, though I don't want to have to support a modified
JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

—

Reply to this email directly or view it on GitHub<
https://github.com/guyboertje/jmongo/pull/4#issuecomment-10975597>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10975909.

jacaetevha · 2012-12-04T14:10:58Z

Thanks. I'll work up a script as well.

Jason Rogers

On Tue, Dec 4, 2012 at 4:53 AM, Guy Boertje notifications@github.comwrote:

no - but I suspect the one that Chuck Remes built to benchmark his first
version of jmongo would work. I think he deleted ithe github repo though.
I might have a copy locally. I will look tonight.

On Mon, Dec 3, 2012 at 10:46 PM, Jason Rogers notifications@github.comwrote:

Do you know of any benchmark suites for it?

Jason Rogers

On Mon, Dec 3, 2012 at 5:37 PM, Guy Boertje notifications@github.comwrote:

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers <notifications@github.com

wrote:

My Java fu is fine, though I don't want to have to support a
modified
JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

—

Reply to this email directly or view it on GitHub<
https://github.com/guyboertje/jmongo/pull/4#issuecomment-10975597>.

—
Reply to this email directly or view it on GitHub<
https://github.com/guyboertje/jmongo/pull/4#issuecomment-10975909>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-10990404.

guyboertje · 2012-12-04T15:54:53Z

read this if you haven't already, about jmongo benchmarking ...

http://www.ruby-forum.com/topic/3841457

Chuck and I replied.

jacaetevha · 2012-12-04T17:01:57Z

Thanks.

Jason Rogers

On Tue, Dec 4, 2012 at 10:54 AM, Guy Boertje notifications@github.comwrote:

read this if you haven't already, about jmongo benchmarking ...

http://www.ruby-forum.com/topic/3841457

Chuck and I replied.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-11002335.

jacaetevha and others added 3 commits June 7, 2010 11:17

fix typo referring to cursor, should have been @j_cursor

fae5847

starting some tests

7119407

updated to use new MongoClient

a1fd34b

merge commit

b68b406

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated to use new MongoClient#4

Updated to use new MongoClient#4
jacaetevha wants to merge 4 commits intoguyboertje:masterfrom
jacaetevha:master

jacaetevha commented Nov 29, 2012

Uh oh!

guyboertje commented Nov 30, 2012

Uh oh!

jacaetevha commented Nov 30, 2012

Uh oh!

jacaetevha commented Dec 3, 2012

Uh oh!

guyboertje commented Dec 3, 2012

Uh oh!

jacaetevha commented Dec 3, 2012

Uh oh!

guyboertje commented Dec 3, 2012

Uh oh!

jacaetevha commented Dec 3, 2012

Uh oh!

guyboertje commented Dec 4, 2012

Uh oh!

jacaetevha commented Dec 4, 2012

Uh oh!

guyboertje commented Dec 4, 2012

Uh oh!

jacaetevha commented Dec 4, 2012

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jacaetevha commented Nov 29, 2012

Uh oh!

guyboertje commented Nov 30, 2012

Uh oh!

jacaetevha commented Nov 30, 2012

Uh oh!

jacaetevha commented Dec 3, 2012

Uh oh!

guyboertje commented Dec 3, 2012

Uh oh!

jacaetevha commented Dec 3, 2012

Uh oh!

guyboertje commented Dec 3, 2012

Uh oh!

jacaetevha commented Dec 3, 2012

Uh oh!

guyboertje commented Dec 4, 2012

Uh oh!

jacaetevha commented Dec 4, 2012

Uh oh!

guyboertje commented Dec 4, 2012

Uh oh!

jacaetevha commented Dec 4, 2012

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants