Skip to content

Fix escaping issue #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dimger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix escaping issue #2

dimger wants to merge 1 commit into from

Conversation

@dimger
Copy link

@dimger dimger commented Oct 1, 2021 •
edited
Loading

If in your pageTheme.php the getThemeResponsiveImageMap function is in use then the generated style from getListingThumbnailImage() breaks the javascript code. See:
https://github.com/concrete5/concrete5/blob/35c800305212cb619cd27cb77ba48b7ea20c8f8c/concrete/src/Html/Object/Picture.php#L89

So i think is better to json_encode the return of getListingThumbnailImage function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TMDesigns TMDesigns TMDesigns approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dimger @TMDesigns