[Task-6] As a user, I can view the sign in page#39
Conversation
c2ca26a to
0573ad8
Compare
0573ad8 to
3152481
Compare
|
@rafayet-monon Sorry I didn't notice Cypress convention. I will try to update the code to follow the convention. |
f3da2dd to
a7ea289
Compare
46d23a2 to
4da5629
Compare
src/components/AuthLogo/index.tsx
Outdated
| return ( | ||
| <div className="auth-logo"> | ||
| <img className="auth-logo__image" src={logoWhite} alt="Nimble" /> | ||
| <p className="auth-logo__label">{label}</p> |
There was a problem hiding this comment.
@gutakk Not sure why do you desire to put this here, IMO this is not quite related to the logo but more like a page title or a form title. So how about moving it out of this component?

There was a problem hiding this comment.
Because I think all auth page have the same layout that's why I named this component as AuthLogo but maybe we can change to AuthTitle to make it clearer. What do you think?
There was a problem hiding this comment.
@gutakk How about page-heder or auth-header, since the title sounds more like the component going to cover only the title? 🤔
carryall
left a comment
There was a problem hiding this comment.
@gutakk One last concern seems like the font-weight does nothing. These two labels with font-weight 800 and 400 look exactly the same 😅
<label class="form-input-group__label" for="password">Password</label>
<label class="form-input-group__label" for="password" style="
font-weight: 400;
">Password</label>You might need to convert the font face to web fonts to fix it. Here's the generator that can help you, at least provide woff woff2 you can take a look at the example from The1 project
src/components/AuthLogo/index.tsx
Outdated
| return ( | ||
| <div className="auth-logo"> | ||
| <img className="auth-logo__image" src={logoWhite} alt="Nimble" /> | ||
| <p className="auth-logo__label">{label}</p> |
There was a problem hiding this comment.
@gutakk How about page-heder or auth-header, since the title sounds more like the component going to cover only the title? 🤔
Fixed in 810a1d6 |

Resolve #4
What happened 👀
Insight 📝
Mock the HTTP request in the UI test using
cy.intercept()and add the mock response tofixturesProof Of Work 📹
Sign in page

CI was passed (Unit and UI test)
https://github.com/gutakk/react-surveyor/actions/runs/935566078