-
Notifications
You must be signed in to change notification settings - Fork 0
Log ARQC command and sanitize dump filenames #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the NFC card extraction tool by adding command logging, fixing dump filename generation, and introducing a rich interactive CLI. The changes improve both the user experience and data extraction accuracy.
- Modifies ARQC generation to return the command APDU alongside response data for better logging
- Sanitizes dump filenames to consistently use the first six digits of Track 2 data
- Replaces basic console output with a Rich-based interactive CLI featuring progress bars, tables, and colored output
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| extrair_nfc_limpo.py | Updates ARQC generation to return command APDU and fixes filename sanitization logic |
| extrair_nfc.py | Major refactor adding Rich UI components, configuration support, and interactive application selection |
| docs/fluxos_emv.md | Adds comprehensive documentation of EMV and magstripe transaction flows |
| config.json | Introduces configuration file for currency codes and output directory settings |
| README.md | Updates documentation to reflect new Rich CLI features and configuration options |
Comments suppressed due to low confidence (1)
extrair_nfc.py:264
- The connection is being established without proper error handling. If the card connection fails, this will cause an unhandled exception that could crash the application.
connection.connect()
| except Exception: | ||
| pass |
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except Exception: without logging or handling the specific exception makes debugging difficult. Consider logging the exception or handling specific exception types.
| except Exception: | |
| pass | |
| except Exception as e: | |
| print(f"Error generating ARQC: {e}") |
| return connection | ||
| except Exception as e: | ||
| print(f"Waiting for card... (Attempt {attempt + 1}/{max_attempts})") | ||
| except Exception: |
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except Exception: without logging or handling the specific exception makes debugging difficult. Consider logging the exception or handling specific exception types.
| except Exception: | |
| except Exception as e: | |
| console.print(f"[yellow]Attempt {attempt+1}: {type(e).__name__}: {e}[/yellow]") |
|
ewr |
Summary
Testing
python -m py_compile extrair_nfc.pypython -m py_compile extrair_nfc_limpo.pyhttps://chatgpt.com/codex/tasks/task_e_68906698b804832492dfef3059b013de