GIT-367 Fixed issue where empty API response are all blocked/treated as error #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where empty API responses with HTTP 200 status codes were incorrectly treated as errors. The primary change allows empty response bodies to be considered valid, particularly for operations like DELETE that may legitimately return no content.
Key changes:
- Added logic to handle empty HTTP 200 responses as valid instead of triggering JSON decode errors
- Updated version from 1.12.3 to 1.12.4
- Added test coverage for empty response handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| trcli/api/api_client.py | Added empty response validation logic and code formatting improvements |
| trcli/init.py | Bumped version to 1.12.4 |
| tests/test_api_client.py | Added tests for empty response handling and metadata header functionality |
| README.md | Updated version references to 1.12.4 |
| CHANGELOG.MD | Added release notes for version 1.12.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being resolved: #367
Solution description
Empty responses with HTTP 200 should be treated as valid for delete operations.
Changes
Update empty response handling.
Potential impacts
None.
Steps to test
Should be able to send test results with fallback or delete operations.
PR Tasks