Skip to content

Conversation

@unroma
Copy link

@unroma unroma commented May 27, 2025

Issue being resolved: #300

Solution description

If custom_automaton_id added using property it won't be set.
Added condition to set custom_automaton_id from property if exist.
In addition adedd condition to set custom_automaton_id if it exist as attribute.

Changes

Added constants for better maintainability.
Added corresponding conditions.
Removed condition which doesn't work:

 if hasattr(case, "custom_case_automation_id") and case.custom_case_automation_id:
                        automation_id = case.custom_case_automation_id

Potential impacts

automation_id value

Steps to test

Add case property custom_automation_id from testcase to set automation_id.
junit xml examlpe:

<testcase name="Test" time="0.001">
                <passed message="No message" type="Passed"/>
                <properties>
                    <property name="testrail_case_field" value="custom_automation_id:automation_id_example"/> 

PR Tasks

  • PR reference added to issue
  • README updated
  • Unit tests added/updated

@unroma unroma changed the title [Fix] Setting custom_autimation_id from property [Fix] Setting custom_autimation_id via property May 27, 2025
@acuanico-tr-galt
Copy link
Collaborator

Hi @unroma Thank you so much for looking into this. Will check.

@unroma unroma requested a review from acuanico-tr-galt June 6, 2025 15:19
@acuanico-tr-galt acuanico-tr-galt merged commit bf23845 into gurock:main Jun 9, 2025
10 checks passed
@unroma unroma deleted the fix/custom_autimation_id_from_property branch June 9, 2025 09:46
@TomLBarden
Copy link

@acuanico-tr-galt Hi, any idea when this is set to be released? Just checking back in on this issue and happy to see that a fix has been merged, keen to make use of this soon!

@acuanico-tr-galt
Copy link
Collaborator

Hi @TomLBarden, apologies for the late response and thank you for your patience. We have released this fix in TR CLI v1.9.13. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set custom_automation_id from property

3 participants