Skip to content

fix: update testrail-php, testrail-nginx + linter fixes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scream314 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: update testrail-php, testrail-nginx + linter fixes #17

scream314 wants to merge 7 commits into from

Conversation

@scream314
Copy link

@scream314 scream314 commented Jul 4, 2021 •
edited
Loading

  • nginx build tested with mainline and stable
    php build tested with
  • PHP 7.3, Ioncube Loader 10.3.9, Testrail 7.0.1.1013-ion71
  • PHP 7.3, Ioncube Loader 10.4.5, Testrail 7.0.1.1013-ion72
  • PHP 7.4, Ioncube Loader 10.3.9, Testrail 7.0.1.1013-ion71
  • PHP 7.4, Ioncube Loader 10.4.5, Testrail 7.0.1.1013-ion72
  • functionality tested with PHP 7.4, Ioncube Loader 10.4.5, Testrail 7.0.1.1013-ion72

scream314 added 6 commits July 4, 2021 14:27
@scream314
feat(testrail-php): update default dependencies
76124f3 
 * php: 7.3
 * ioncube: 10.4.5
 * testrail: latest-ion72
@scream314
fix(testrail-php): add missing apt packages
c216845 
 * libonig-dev
 * libzip-dev
@scream314
fix(testrail-php): add pdo and pdo_mysql php libraries
a713e14
@scream314
fix(testrail-php): use uname to figure out arch
aaf39ac 
Use `uname -m` to get the architecture for the `docker-php-ext-configure ldap --with-libdir=...` command.
This aides multiarch builds (with `docker buildx build`).
@scream314
fix: yamllint issues in composefiles
4075872
@scream314
fix: shellcheck errors
1cbd662
Desperado
Desperado approved these changes Jul 5, 2021
View reviewed changes
Copy link

@Desperado Desperado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scream314 scream314 changed the title wip: various fix: update testrail-php, testrail-nginx + linter fixes Jul 14, 2021
@scream314 scream314 marked this pull request as ready for review July 14, 2021 23:53
@RomainTT
Copy link
Contributor

RomainTT commented Feb 15, 2022

Is someone in charge of accepting pull requests at Gurock ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Desperado Desperado Desperado approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scream314 @RomainTT @Desperado