Skip to content

Fix compilation with GCC 15.x.y #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alt-graph merged 1 commit into from
Mar 20, 2025
Merged

Fix compilation with GCC 15.x.y #102

alt-graph merged 1 commit into from
Mar 20, 2025

Conversation

@soerengrunewald
Copy link
Collaborator

@soerengrunewald soerengrunewald commented Mar 20, 2025 •
edited by Finii
Loading

[Why]
The compilation with GCC 15 fails with:

In file included from tests/incl_SmallVector.cc:23:
include/gul14/SmallVector.h:277:22: error: ‘uint32_t’ does not name a type [-Wtemplate-body]
  277 |     using SizeType = uint32_t;
      |                      ^~~~~~~~
include/gul14/SmallVector.h:37:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include  <stdint>’
   36 | #include "gul14/cat.h"
  +++ |+#include <cstdint>
   37 |

@soerengrunewald
SmallVector: Add missing include
a92ec64 
[Why]
The compilation with GCC 15 fails with:
> In file included from tests/incl_SmallVector.cc:23:
> include/gul14/SmallVector.h:277:22: error: ‘uint32_t’ does not name a type [-Wtemplate-body]
>   277 |     using SizeType = uint32_t;
>       |                      ^~~~~~~~
> include/gul14/SmallVector.h:37:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include <cstdint>’
>    36 | #include "gul14/cat.h"
>   +++ |+#include <cstdint>
>    37 |

Signed-off-by: Soeren Grunewald <soeren.grunewald@desy.de>
@soerengrunewald soerengrunewald added the bug Something isn't working label Mar 20, 2025
@Finii
Copy link
Member

Finii commented Mar 20, 2025

Fixing formatting error...

header ''

image

@Finii
Copy link
Member

Finii commented Mar 20, 2025

How strange, -Wtemplate-body is mentioned indirectly here, but not explained...

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

alt-graph
alt-graph approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@alt-graph alt-graph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alt-graph alt-graph merged commit 2dca8e3 into main Mar 20, 2025
3 checks passed
@alt-graph alt-graph deleted the bugfix/fix-compilation-with-gcc15 branch March 20, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Finii Finii Finii approved these changes

@alt-graph alt-graph alt-graph approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soerengrunewald @Finii @alt-graph