fix: generate es modules instead of commonjs for npm packages #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketraman
reviewed
Nov 26, 2025
| "npx", "tsc", "--init", | ||
| "-d", | ||
| "--module", "ES2020", | ||
| "--moduleResolution", "node", |
Contributor
There was a problem hiding this comment.
Typescript docs indicate this should not be used for new projects (https://www.typescriptlang.org/docs/handbook/modules/reference.html#node10-formerly-known-as-node).
I would imagine bundler might be more appropriate for code that is going to target RN or the web?
Also note this from the docs:
--moduleResolution bundler must be paired with --module esnext or --module preserve.
Test results: React Web (Vite/Webpack): - Uses bundlers that handle ESM perfectly - controlresell web app already uses bundler resolution - Will work seamlessly React Native (Metro): - Metro bundler supports ES modules - controlresell-app uses bundler resolution - Will work seamlessly Node.js: - With "type": "module" in package.json, Node.js handles ESM natively - Confirmed working in our test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35