-
Notifications
You must be signed in to change notification settings - Fork 4
feat: support for codeberg host #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |||||
|
|
||||||
| module Krank.Types | ||||||
| ( GithubKey (..), | ||||||
| CodebergKey(..), | ||||||
|
||||||
| CodebergKey(..), | |
| CodebergKey (..), |
Copilot
AI
Dec 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment "The codeberg host token" is inconsistent with the other token comments. The GitHub comment says "oAuth token" (line 63) and GitLab says "oAuth token" (line 65). For consistency, this should be "The codeberg oAuth token" to match the pattern.
| -- | The codeberg host token | |
| -- | The codeberg oAuth token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
Codebergvariant lacks test coverage. The test suite attests/Test/Krank/Checkers/IssueTrackerSpec.hscontains comprehensive tests for GitHub and GitLab URL parsing (usinggiturlTests), but no tests are added for Codeberg. Consider adding test cases for Codeberg by callinggiturlTests Codebergin the spec to ensure the implementation works correctly.