Skip to content

Migrate to trusted publishing#472

Merged
SHession merged 8 commits intomainfrom
sh/migrate-to-trusted-publishing
Mar 26, 2026
Merged

Migrate to trusted publishing#472
SHession merged 8 commits intomainfrom
sh/migrate-to-trusted-publishing

Conversation

@SHession
Copy link
Copy Markdown
Contributor

What does this change?

Attempt to bump Pan Domain Node to trusted publishing. Following:

How to test

Testable by going through the release process and checking the results

How can we measure success?

We are able to successfully publish package updates.

@SHession SHession requested a review from a team as a code owner March 25, 2026 08:07
@SHession SHession force-pushed the sh/migrate-to-trusted-publishing branch from c8c69bf to 49a904b Compare March 25, 2026 08:09
@SHession SHession added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Mar 25, 2026
@SHession SHession self-assigned this Mar 25, 2026
@emdash-ie emdash-ie self-assigned this Mar 25, 2026
@emdash-ie
Copy link
Copy Markdown
Contributor

The DevX guide quoted in https://github.com/guardian/workflow/issues/1285 suggests we should add id-token: write to the release workflow, and (possibly?) that we should change the url field to a full object – do we need to do those things here?

Copy link
Copy Markdown
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for my questions above!

@SHession
Copy link
Copy Markdown
Contributor Author

SHession commented Mar 26, 2026

The DevX guide quoted in guardian/workflow#1285 suggests we should add id-token: write to the release workflow, and (possibly?) that we should change the url field to a full object – do we need to do those things here?

Good point about the permissions, I have updated this.

It looks like the way we have set up repository is an accepted shortcut, so I expect it will be fine. It's easy to change if not.

EDIT: this did show an error so I've changed it: https://github.com/guardian/prosemirror-elements/actions/runs/23584205609/job/68673854803#step:7:36

@SHession SHession force-pushed the sh/migrate-to-trusted-publishing branch from 4dbe725 to 00110d8 Compare March 26, 2026 09:00
@SHession SHession force-pushed the sh/migrate-to-trusted-publishing branch from dc52d37 to 70e3556 Compare March 26, 2026 13:45
@SHession SHession merged commit 383829c into main Mar 26, 2026
12 of 13 checks passed
@SHession SHession deleted the sh/migrate-to-trusted-publishing branch March 26, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants